Giter VIP home page Giter VIP logo

metalsmith-code-highlight's People

Contributors

dependabot[bot] avatar fortes avatar greenkeeper[bot] avatar leslc avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

metalsmith-code-highlight's Issues

Transform looks for all <code>, not <pre><code>

My main usecase is that I have <code> tags that I don't want marked up by this plugin, but I still want the highlight for other code blocks.

I was writing some <code> elements that I wanted inline. The relevant DOM structure is
<li>blah blah text <code>$ cowsay </code> more text </li>, which will still be highlighted, and the code gets marked up because the the sourcecode looks up all <code>. If I have subsequent <code> elements in that <li>, nothing happens to them; they won't have the hljs class (not sure why).

highlight.js says that it finds <pre><code> tags.

Why does the sourcecode select all code instead of 'pre > code'?

Version 10 of node.js has been released

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

  • Replaced the old Node.js version in your .nvmrc with the new one

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

More information on this issue

Greenkeeper has checked the engines key in any package.json file, the .nvmrc file, and the .travis.yml file, if present.

  • engines was only updated if it defined a single version, not a range.
  • .nvmrc was updated to Node.js 10
  • .travis.yml was only changed if there was a root-level node_js that didn’t already include Node.js 10, such as node or lts/*. In this case, the new version was appended to the list. We didn’t touch job or matrix configurations because these tend to be quite specific and complex, and it’s difficult to infer what the intentions were.

For many simpler .travis.yml configurations, this PR should suffice as-is, but depending on what you’re doing it may require additional work or may not be applicable at all. We’re also aware that you may have good reasons to not update to Node.js 10, which is why this was sent as an issue and not a pull request. Feel free to delete it without comment, I’m a humble robot and won’t feel rejected 🤖


FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Latest tag on npm is not up to date

On npm, latest version is not up to date. It requires highlight.js 9, which is no longer supported. Where version 10 is in use in this git repository. It produces the following error:

Version 9 of Highlight.js has reached EOL and is no longer supported.
Please upgrade or ask whatever dependency you are using to upgrade.
https://github.com/highlightjs/highlight.js/issues/2877
# package.json from https://registry.npmjs.org/metalsmith-code-highlight/-/metalsmith-code-highlight-1.1.0.tgz
# [...]
  "dependencies": {
    "highlight.js": "^9.12.0",
    "metalsmith-dom-transform": "^2.0.0"
  },
# [...] 

Action required: Greenkeeper could not be activated 🚨

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because we are using your CI build statuses to figure out when to notify you about breaking changes.

Since we did not receive a CI status on the greenkeeper/initial branch, we assume that you still need to configure it.

If you have already set up a CI for this repository, you might need to check your configuration. Make sure it will run on all new branches. If you don’t want it to run on every branch, you can whitelist branches starting with greenkeeper/.

We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

Once you have installed CI on this repository, you’ll need to re-trigger Greenkeeper’s initial Pull Request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper integration’s white list on Github. You'll find this list on your repo or organiszation’s settings page, under Installed GitHub Apps.

pandoc markdown code blocks

Hi!
So if one use pandoc, this code:

```js
var int = 0;
```

will render to this HTML:

<pre class="js">
  <code>var int = 0;</code>
</pre>

which means getLanguage(element) will fail.

As I think this is a common setup, would you approve a PR for a getLanguage(element) that also looks into if element got a parent which is <pre> with a language class?

Support for entire HTML document

Hi @fortes,

Thanks for this metalsmith plugin. It currently supports HTML fragments, but not an entire HTML document (strips out DOCTYPE, html, head, and body tags). I will submit a pull request to you if you'd like to incorporate the change.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.