Giter VIP home page Giter VIP logo

rfaboutview-swift's People

Contributors

bcylin avatar fouquet avatar jholzerinovex avatar paulot avatar steets250 avatar tnantoka avatar wooder avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

rfaboutview-swift's Issues

addbutton with action selector

Great library, it's really convenient for me. Just wanted to ask if you could implement a button that allows a method selector instead of just a String as well.
Best regards.

Allow manual additions to acknowledgements

As a feature request:

The convenient Acknowledgements.plist file from cocoapods is a nice touch.
However, many of our projects use a combination of pods and other sources. That leaves us to manually modify the .plist file or modify the private function reformatAcknowledgementsDictionary to devise a custom solution (cannot override the function as it is marked private. We could also just extend or replace the acknowledgements class var but it, too, is private.)

Would it be possible to extend the API a bit to allow taking a dictionary of manually generated acknowledgements to append to the end of the automatically generated details?

Close back to black screen

I am using Xcode 7.1.
I have only a ViewController with a button who open the AboutView, when i click in close About return black screen.

Incorrect UI centering when using on iPad in modal=.formSheet

When using the controller with an iPad but presenting it in a modal = .formSheet the UI overall for the App Info, copyright, email etc... is not centered properly.
A quick glance into the code, and I think the assumption made in the function

    func sizeForPercent(_ percent: CGFloat) -> CGFloat {
        if UIDevice.current.userInterfaceIdiom == .pad {
            return ceil(((view.frame.size.width * 0.7) * (percent / 100)))
        } else {
            return ceil(view.frame.size.width * (percent / 100))
        }
    }

is slightly incorrect, since it is assuming on iPad the VC is presented full screen... In addition, it's not only the userInterfaceIdiom and the modal presentation that should be checked but in case of an app supporting slideOver the frame maybe even different.
Thanks!

Crash: Dictionary

I get this error:

fatal error: unexpectedly found nil while unwrapping an Optional value

On the following line: (in reformatAcknowledgementsDictionary)

for innerDict: AnyObject in theDict {
/* -> */ outputArray.addObject(["title":innerDict["Title"] as! String,"content":innerDict["FooterText"] as! String])
}
//EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0)
//Cast from '[SKNODE]!' to unrelated type 'String' always fails

Button Close is not appearing

Ive download with cocoa pods and when i open the ViewController the button close is not appear. Do u know how to fix it?

Back button do not show

-(void) showAboutView{
UINavigationController *aboutNavigation = [UINavigationController new];

RFAboutViewController *aboutView = [[RFAboutViewController alloc] initWithAppName:nil appVersion:nil appBuild:nil copyrightHolderName:@"APP Be Easy" contactEmail:@"[email protected]" titleForEmail:@"Contato" websiteURL:[NSURL URLWithString:@"http://appbeeasy.com"] titleForWebsiteURL:@"appbeeasy.com" andPublicationYear:nil];

aboutView.headerBackgroundColor = [UIColor blackColor];
aboutView.headerTextColor = [UIColor whiteColor];
aboutView.blurStyle = UIBlurEffectStyleLight;
aboutView.headerBackgroundImage = [UIImage imageNamed:@"about_header_bg.jpg"];

[aboutView addAdditionalButtonWithTitle:@"Política de privacidade" subtitle:@"" andContent:@"some text."];

[aboutNavigation setViewControllers:@[aboutView]];

[self presentViewController:aboutNavigation animated:YES completion:nil];

}

Font as public var

please make the font parameterized and i am the happiest user of you code ;-)

Crash Dictionary 2

Now I get this error:

1. EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0)
2. Cast from '[SKNODE]!' to unrelated type 'String' always fails
(fatal error: unexpectedly found nil while unwrapping an Optional value)

At this line:

if tableView.tag == 0 {
      title = self.additionalButtons[indexPath.row]["title"] as! String //this is error 1
} else {
      title = self.acknowledgements[indexPath.row]["title"] as! String //this is error 2
}

I dont know if it is my Acknowledgement.plist, but If I put the original file in my project it does not work either. But your example works fine, and a new project I created is also working fine.

Compiler problem related to UIDevice.currentDevice calls. Help?

There's a problem with lines 442 and 443 of RFAboutView.swift. If I declare them the following way:

let iOSVersion = UIDevice.currentDevice().systemVersion as String
let device =  UIDevice.currentDevice().model as String

the compiler bugs out compiling the file. It doesn't show me an error in the IDE (tried both Xcode and AppCode), but it just won't compile. I get the following error:

Global variable initializer type does not match global variable type!
%struct._class_t** @"\01L_OBJC_CLASSLIST_REFERENCES_$_"
LLVM ERROR: Broken module found, compilation aborted!

No idea what the issue is. The code works great outside RFAboutView.swift, so it's apparently not syntax related. I don't know if this is a compiler bug, or there's just something screwed up on my machine, but I just can't fix it. Maybe someone has some insight in this. Thanks!

Until this compiles on my machine these variables will stay empty, unfortunately :(

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.