frcsty / frozenjoin Goto Github PK

If a player leaves the server the leave message doesn't include the name of the player when %essentials_nick% is used in the leave message.

Basically, I do everything that it asks for, put the generate command, put the file in the folder itself, hit start ... but when start it says that the same folder does not exist BUT IT IS CREATED AND WITH THE FILE INSIDE

ormats:
default:
priority: 1
type: 'NORMAL'
join:
- '[BROADCAST] &8[&a+&8] &6%vault_prefix% &6%essentials_nickname%'
- '[TITLEMESSAGE] Welcome to CompetitorsPC Mine&7craft;20;80;20'
- '[ACTIONBARBROADCAST] &6%vault_prefix% &6%essentials_nickname% &6is online'
#- '[TITLEMESSAGE] &6Welcome to &cCompetitorsPC &2Mine&7craft;20;80;20'
quit:
- '[BROADCAST] &8[&c-&8] &6%vault_prefix% &6%essentials_nickname%'
- '[ACTIONBARBROADCAST] &6%vault_prefix% &6%essentials_nickname% &6went offline'
permission: 'frozenjoin.default'

The plugin isn't displaying text colors or parsing placeholders that are used in the title screen or the action bar.

ex. &6Competitors %essentials_nickname%

shows up exactly like that instead of gold text reading "Competitors MrSqueak the Admin"

I'm using FrozenJoin 2.3.0 on paper 1.16.5, and I made a custom javascript that check for player permission to display a custom rank when player connect/disconnect.

When he connect it works fine, but when he disconnects it doesn't parse it (seems an issue where the player is already offline when it parses the javascript, so it can't detect his permission.)

It would be possible to save in cache or parse the placeholder before the player is offline ?

As the title explains;

Instead of only having [CENTERMESSAGE] which centers a message.
It would be nice with the possibility to center a JSON message aswell.

Possible switch to adventure/minimessages.

I am thinking at first we should use both a legacy serializer and minimessages. I know I know. not the best. But in the meantime we give people 1 version to use our new legacy to minimessages converter to convert and we can also fix possible bugs in the minimessages converter if any occur so the update after will remove complete legacy support with an easy and reliable way to convert.

The converter will work something like this: (at least for strings). We convert the current hex formats to &#aaFF00 then we use a legacy converter to convert it to components then we use the mini messages serializer to serialize the components to string. ez convertor idea.

Having the possibility to add a delay to an entire MOTD would be fantastic. Instead of individual lines..

Something like:

motds:
default:
priority: 1
permission: frozenjoin.motd.default
delay: 2s
actions:
- '[MESSAGE] &f'

Would be awesome

I will be marking each issue as I fix it locally.

• Title actions do not parse colors

• Help command needs updating (there is no /fj info command anymore. it is just /fj)

• The motd command is no longer a subcommand of /fj anymore (why?)

• Version needs bumping

• Still using gradle groovy? smh.

• The extensions classes seem to be a duplicate of each other (almost). Why?

• Hex doesn't work on 1.17 lol. bcz version check only checks if it is 1.16

• NMS might not work in 1.17 (will have to double check).

• Delay seems to not be working (needs more looking at).

• Chance seems to not be working (needs more looking at).

• According to an older PR, the getHandlers method in the FJ events should be static. (need to check)

• nms was completely removed as it was just for 1.8 support which is no longer a thing.

• hex checks were removed since this plugin only works on 1.17+.

That is all for now. I Will be updating the list as I Find new issues.

Have not tested yet personally but according to: <@210829026359508993> on discord, it doesn't parse.

They've used this format: https://gyazo.com/aff478a4f8e00770961e0365ba0a45bb
This is their server version: https://gyazo.com/3102db777d3cfddb57cdf14d0e262ed7

My assumption is that the HEX_USE is broken. I will have to test and see if I can find a fix sometime if I don't forget. Welp the whole reason for opening this issue is to not forget but I probably will anyways.