fredrikloch / hugoscroll Goto Github PK

Hey, there's a missing close paren layouts/index.html on line 5

<header id="site-head" {{ if .Site.Params.cover }}style="background-image: url({{ .Site.Params.cover }}"{{ end }}>

See, right before "{{ end }}>

that should be:

<header id="site-head" {{ if .Site.Params.cover }}style="background-image: url({{ .Site.Params.cover }})"{{ end }}>

The cover image won't display on Chrome without the close paren. It will still display properly on Firefox.

Hi @fredrikloch, I just stumbled upon this repo.

Funnily enough I just released

https://github.com/janraasch/hugo-scroll

a few days ago. Looks quite similar 😛.

If you like, I could spin up a quick pr to point people into the direction of https://github.com/janraasch/hugo-scroll in case they'd like to have a look at an up-2-date version of this theme.

Let me know, what you think.

PS:

Nice photographs (on https://fredrikloch.me/)!!! (I need to go to Sweden (once Covid is »over«... 🤞🏻))

Wouldn't it be more useful to use the javascript for the fixed nav on the header buttons under the title? The first and last post concept is quite limiting for a useful navigation menu.

Is it possible to use page parameters as detailed here?

I am trying to replicate the example at the aforementioned link, with no success as the parameters remain blank.