OptionsDB::Commit() destroys options in config.xml if they have not yet been Add()ed to the OptionsDB. about freeorion HOT 4 CLOSED

Or it could be done by adding unrecognised options as std::string options with a flag that marks them as unrecognised (so Get(), Add() etc. can still behave like they don't really exist) which would simplify writing them all back to XML in alphabetical order.

from freeorion.

As suggested, Options set by SetFromXMLRecursive (and perhaps SetFromCommandLine) that don't find an existing already-Added option in the DB could add a string-valued Option to the map.

When Adding an option in code, it checks for an existing option by the same name already, and throws an exception if a duplicate is found.

Instead, it could set the value of the new Option to whatever is already set in the existing Option by taking the result of the existing Option's GetValueString() function, and attempting to lexical_cast that to whatever the newly-Added Option's type is.

No need for an extra flag, I think.

If the lexical_cast fails, then use the default value of the newly-Added Option.

from freeorion.

That approach wouldn't allow functions such as Get(), Validate() or OptionExists() to tell the difference between options that have been registered with Add() (and therefore have the proper type info, validators, descriptions, defaults etc.) and ones that were merely found in the config or command line with no context. I just threw up a PR with the "save as a string Option with a flag" approach over here if you'd like to inspect it. Haven't done anything with SetFromCommandLine there but it would make sense for that to behave similarly to SetFromXMLRecursive.

from freeorion.

Seems reasonable

from freeorion.