Comments (2)
matthias-wende-frequenz
commented on June 12, 2024
1
This change doesn't pass protolint with the following error message:
Repeated field name "public_trades_list" must be pluralized name "public_trades_lists"
My suggestion would be to remove the lists suffix at all because that fact that this is a list is part of the type and as such visible for the user.
In that case the field would be called public_trades and the repeated keyword would induce that this is a list type.
from frequenz-api-electricity-trading.
camille-bouvy-frequenz
commented on June 12, 2024
Done in #47
from frequenz-api-electricity-trading.
Related Issues (12)
- Add unit conversion methods to Energy type
- Remove unnecessary optional keywords and add documentation to `UpdateGridpoolOrderRequest` HOT 11
- Revert copying proto definitions from the frequenz-api-common repository.
- Update documentation on `PublicTrade` message HOT 1
- Return gridpool trades HOT 6
- Split `OrderState` into `OrderState` and `TradeState` HOT 5
- Return full order revision history
- Error in API Response Handling HOT 1
- Split `OrderState.PENDING` in `UPDATE_PENDING` and `CREATE_PENDING` HOT 1
- Remove `filled_quantity` field from `OrderDetail` message HOT 4
- Remove state filter from OrderFilter
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from frequenz-api-electricity-trading.