Comments (4)
Was this completed? It shouldn't have been done because we agreed not to remove this field in the end
from frequenz-api-electricity-trading.
We agreed that one of filled or open can be removed due to redundancy. In case I missed the discussion about not removing it, can you please give context, why this shouldn't be removed?
from frequenz-api-electricity-trading.
We agreed that one of filled or open can be removed due to redundancy
When or where? I thought we concluded on not removing it but I cannot find this conversation and my memory might be tricking me.
why this shouldn't be removed?
Currently, the app is using the filled_quantity field to make some informed trading decisions. This could indeed be deducted by the subtraction but I think it's more intuitive & user friendly to have both. I also looked into how other markets were doing and they have a similar approach, I don't think it's that terrible to keep both to be honest.
from frequenz-api-electricity-trading.
ChatGPT's take on it:
In the context of designing an API for electricity trading, the presence of open quantity, filled quantity, and the original quantity fields in the OrderDetail
message can indeed be seen as redundant from a strict data normalization perspective. However, redundancy in API design is not always a bad practice, especially if it enhances usability and reduces the likelihood of client-side calculation errors.
In financial and trading markets, APIs often prioritize usability and convenience, sometimes at the cost of strict normalization. It's common to see APIs providing both open and filled quantities for the reasons mentioned above. Given the context and the typical practices in trading APIs, retaining both open_quantity
and filled_quantity
fields in the OrderDetail
message is justified. It aligns with a user-centric approach, ensuring that users have all the necessary information at their fingertips without needing to perform additional calculations.
from frequenz-api-electricity-trading.
Related Issues (12)
- Add unit conversion methods to Energy type
- Remove unnecessary optional keywords and add documentation to `UpdateGridpoolOrderRequest` HOT 11
- Revert copying proto definitions from the frequenz-api-common repository.
- Update documentation on `PublicTrade` message HOT 1
- Return gridpool trades HOT 6
- Split `OrderState` into `OrderState` and `TradeState` HOT 5
- Rename `public_trade_lists` to `public_trades_list` for better clarity HOT 2
- Return full order revision history
- Error in API Response Handling HOT 1
- Split `OrderState.PENDING` in `UPDATE_PENDING` and `CREATE_PENDING` HOT 1
- Remove state filter from OrderFilter
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from frequenz-api-electricity-trading.