freyaholmer / mathfs Goto Github PK

The code uses modern C# 9.0 features which are not available on Unity 2020 (which is the current LTS). Do you want:

• it to be Unity 2021+ compatible, or
• port code back into C# 8.0

I'm getting kinda involved with all this at this point, so I can help with the second one.

V small issue. Love the library by the way, but thought I'd mention a small issue I encountered. In the readme you specify "com.acegikmo.mathfs": "https://github.com/FreyaHolmer/Mathfs" as the entry to add to the package manifest, but for me it only works when it's "com.acegikmo.mathfs": "https://github.com/FreyaHolmer/Mathfs.git" or "com.acegikmo.mathfs": "git+https://github.com/FreyaHolmer/Mathfs"

Hey @FreyaHolmer ! An awesome contribution! Perhaps You are open making this as a unity package ? If You do not know how - i can fork it and open as pull request :)

Hey, Freya!

In the Catenary3D constructor, the space is being initialized to default after p0 and axisY are set, which is causing the transformation not to work when only the constructor is used to create the struct. I've fixed it on my local copy of the lib but thought I should let you know :)

And thanks for the awesome library!

Just came across this repo, and it looks fantastic!
I've been in the process of more heavily investing in Burst optimizing static functions, and this package looks largely static to begin with.

Any chance it could leverage mathematics utilities and structs instead of the ones in the old math library, so that they could automatically be optimized using the compiler optimizations supported by the new math library?

Hi Freya,

Thank you for this incredible library! I noticed that Box2D.Contains method doesn't account for a world position, checking just extents.