friendsincode / els-plus Goto Github PK

Preset patterns over 63 for Primary lights (PRML) do not work and error out,
Preset patterns not set to 0 on Secondary(SECL) and Warning lights (WRNL) do not work and error out.

Temporary fix is to set the preset pattern enabled setting to false

Doesn't seem to be a sync issue, some players get the ELS+ lagging the resource, some have no issues at all, attempted several hot fixes, to no avail.

[ ] investigate Different ways to achieve Environment lighting.

Morning

Im looking at using this els script but want to use wm serversided sirens with it or is there a way to install my own sirens within the script ?

How do i go around doing this

Thanks

I installed a ELS car but nothing happens, and on the normal police cars doesn't work.

Spawning and getting into a non-networked vehicle will spam the console with:

repro code:

RequestModel("taxi")
while not HasModelLoaded("taxi") do
	Citizen.Wait(100)
end
playerCoords = GetEntityCoords(GetPlayerPed(-1))
currentGoKart = CreateVehicle("taxi",playerCoords.x,playerCoords.y,playerCoords.z,0.0,false,false)
TaskWarpPedIntoVehicle(GetPlayerPed(-1), currentGoKart, -1)

This spam is caused by els, as stopping the resource stops the spam, I assume its constantly trying to call NetworkGetEntityFromNetworkId

what does this do does this stop the random els stop working moments?

allow the use of the Alt modifier key to choose a lower pattern number

Anyone able to tell me how to fix that? Is it my xml or the carvariations, or is it ELS plus related only?

Currently for the bug you cannot enter the map using P or the Start Button(xbox) when in a ELS vehicle.

And for a suggestion add a way to use B Button(xbox) to cycle through sirens when in LS3 and blip your siren when not in LS3(in LS2, LS1, and none).

A question: The walls and grass seem to light up, but the ground doesnt. I dont know if thats a bug or something with my visual mod.

Thank you.

https://youtu.be/aFfrnvCUaX8

I've got everything set up and installed properly. Screens from one of my cars:

But we get this error in the console/chat:
"Instantiated instance of script ELS_Server.Class1."

And 2 different errors in the F8 console:
https://imgur.com/a/ABJ4nJq

How do I fix this because some cars don't work well either

Can this be solved?
Or do you have to use the new version, but I don't know how to convert a source code to a release.

I was testing some new cars today and I noticed when I turned the ELS control panel on the numbers were not changing while I was changing patterns, nor were the lights syncing on the panel. It seems to stop working when you have your lights on and exit the vehicle and get back in. here is a video https://youtu.be/cHh1b52w2pE I will keep this issue updated if I figure anything else out.

When you turn the ELS on the vehicle, the vehicle fixes.

I can’t start els-plus I followed all the instructions but I couldn’t, because I can’t find the __resource.lua in els-plus.
You can help me?

Listening for when a resource starts can allow the server to automatically push and update new configs.
and listening for stopping can be used to run specific cleanup code.

Whenever a vehicle is suddenly deleted (not sure if the same case is true for exploded vehicles) by for example esx_jobs it seems to not realise the vehicle is gone and after a while it starts massively spamming the console quite a bit.
Another issue is with certain garage plugins which don't network the cars to other players (ESX has commands built in to spawn only locally) and this causes massive lag because of the amount of console spam the errors produce because it tries to get a non existent network ID, I tried fixing it myself with NetworkGetEntityIsNetworked() but didn't really know where to put the checks exactly so just ended up causing more and more issues with NullPointers.
I'm running the latest builds from the dev branch from the friendsincode (https://git.friendsincode.com/PFM/ELS-Plus/tree/dev) couldn't send an issue there without an account so did it here instead.

Not important (edited)

Can someone provide me a link to get this, please?

I have been using ELS-Plus for my fiveM server for a while now. But since the time that there are 2 or more players in my server and vehicles are used that have ELS, everyone who is in an ELS vehicle is picked / crashed with the reason: Network Overflow.

Case is we got a carshop, where you can see the vehicle before you buy them.
The entity/vehicle is created as non-networked, as it is not needed.

This causes els-plus to spam this in client-console:

Notice this is on FiveM with OneSync enabled. If I make the entity networked, the error is gone.
But as we dont need the entity to be networked, then... yeah 🤷‍♂

Hello folks,
I'm getting this error/messages

ELS-Plus: Checking firetruk.xml
ELS-Plus: XML Pattern data for firetruk.xml is not valid

Could someone give some more information about this message? I get this message with a lot of the .xml els files.

Kind regarts,

there is no __resource file included, maybe I can get one made or a link to a place I can download _it?

Having multiple users in ELS cars turning on/off the lights will turn them on/off for everyone etc

everytime we have a patrol the server slows to a crawl almost stopping any plugin files to be streamed. And Only happens when more then 3 els cars are running lights.

Add the ability to enable or disable the indicators based on settings in the ini

I seriously need someone to help me install this I am so lost with the tutorial and my server wont start because I did it wrong.

Some cars do this as others do not (all cars are ELS models) when on the scene with lights on just sitting their serine is off, they make quick serine blip sounds but once the user leaves the car with lights on it stops

Followed all instructions and I don't get any error in the command prompt.
When I go to join the server it says it cannot load the resource.
I've tried on my public server, and on a fresh made local server. Both give me the same thing.
Does regular ELS need to be installed? If so that could be my problem!
If not, I have no idea...

I have a lot of network oveflows since i enabled onesync infinity on our server. I opened Network Event Log and i see a lot of ELS spamming mostly ELS:FullSync:removestale if i could get some help it would be nice. Maybe discord is easier but i don't have your discord link.

UI on start stays opened and will not close.
ELS Vehicles not being detected even with is_els = true at the bottom of a resource lua. Had no issues with previous version, only latest update found on the git page

This is caused by the script not being able to get a valid NetworkID from a vehicle.
This occurs when using:

• Lambda Menu
• Getting into one of the police car that spawn at police station

Im trying to do: git clone https://git.friendsincode.com/PFM/ELS-Plus.git and I get prompted for credentials, which I can't see anywhere which is? :)

And why is there not a pre-build version just to grab?

make a configuration class that parses all the xml data with the toString stuff to there appropriate datatypes so it does not need to be done everytime in the frame.

That error shows up when anyone tries to join.

When i use els plus om my qb-core server all my cars are turning on when this is not nessesary how can i fix this

Collection modification issues can cause lights to stop working during stale Vehicle removal

This has to deal with, how the UI is being handled.

I believe I installed the ELS correctly on my server, but it does not work. Could you maybe give some more explaination in how to set it up?

--[[
ELS FiveM - A ELS implementation for FiveM
Copyright (C) 2017 E.J. Bevenour

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU Lesser General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU Lesser General Public License for more details.

You should have received a copy of the GNU Lesser General Public License
along with this program.  If not, see <http://www.gnu.org/licenses/>.

]]
resource_manifest_version '05cfa83c-a124-4cfa-a768-c24a5811d8f9'
local NUIEnabled = false

-- XML Processing Requirements
client_script 'System.Xml.net.dll'

-- ELS-FiveM Requirements
client_script 'SharpConfig.net.dll'
client_script 'ELS-FiveM.net.dll'

-- NUI Stuff
if NUIEnabled then

client_script 'NUI/api.lua'

ui_page('NUI/app/index.html')

files({
	'NUI/app/index.html',
	'NUI/app/js/vue.js',
	'NUI/app/js/app.js'
})

end

-- Server Events
server_script 'ELS-Server.net.dll'

files({
'extra-files/ELS.ini',
'extra-files/POLICE.xml',
'extra-files/POLICE3.xml',
'extra-files/POLICEOLD2.xml',
'extra-files/FBI.xml',
'extra-files/FBI2.xml',
'extra-files/burrito4.xml',
'extra-files/AMBULANCE.xml',
'extra-files/ASTEROPE.xml'})

is_els 'true'

I'm fine with the controls for the controller but is there a way that I can change the keys for the keyboard users. There are some things that I want to take out or at least change what key they are on. I can't find what key codes these ones match to in the INI.

Having an issue with door spam when using ELS-plus. This happens at random and is uncontrollable. Help would be much appreciated.

https://gyazo.com/99e8f5907a7d69a6ce22e28e84ecf3c1

Current build on git

when spamming horn or sirens it causes clients to lag out

https://github.com/ejb1123/ELS-FiveM/blob/af490dd71a772dc32e1c2a71e1209c7ae412cdd1/src/Light/Lights.FullSync.cs#L82

When entering or exiting an els vehicle if stages or lights are running states are not properly saved for UI