friendsofflarum / secure-https Goto Github PK

Bug Report

Current Behavior
Users excpet admin are unable to view images when "Proxy images through HTTPS" is on.

Steps to Reproduce

1. Enable "Proxy images through HTTPS" in settings.
2. Log out and check images in posts.

Expected Behavior
All users with "viewForum" permission should be able to view images via through proxy.

Environment

• Flarum version: 1.6.2
• Extension version: 1.1.0

Possible solution(s)

The problem is at

remove extra space in 'viewForum ' .

When using FoF Secure HTTPS, BBCode Images do not work,

Steps to reproduce:

1. Enable Secure HTTPS
2. On ANY thread, embed a BBCode image as follows: [img]{URL}[/img]
3. Save the post, and check the image.

It's returning an image URL of : https://creatorswave.com/api/fof/secure-https/https%3A%2F%2Fwinaero.com%2Fblog%2Fwp-content%2Fuploads%2F2015%2F05%2FWindows-10-banner-logo-devs-04.png for example.

This leads to a broken image and also leads to the following error message on the site:
https://i.imgur.com/Y9YEkYo.png

Bug Report

Current Behavior
The original http:// link is left completely untouched if Markdown is used while BBcode is disabled.

Steps to Reproduce

1. Disable proxy feature
2. Disable bbcode extension
3. Insert HTTP image using Markdown or AutoImage

Expected Behavior
Should be supported.

Environment

• Flarum version: 1.6.0
• Extension version: dev-main

Output of "php flarum info", run this in terminal in your Flarum directory.

Possible solution(s)
The problem is at

When the bbcode extension is disabled, images don't have a title attribute and the regex never matches anything.

After installing and enabling the v17development/flarum-blog plug-in, the picture preview in the blog list and the header picture of the specific blog page (which is a picture with the list preview) are not proxied, and the picture source of http protocol is not displayed

In the ModifyContentHtml subscriber, UrlGenerator is resolved during the extension booting sequence, preventing any more extension from registering routes. This means all routes defined by extensions enabled after secure-https will return 404 errors.

Bug Report

Current Behavior
Non-admins can't use the image proxy.

Screenshots

Possible solution(s)
We use viewDiscussions permission which as renamed to viewForum in Flarum.

Additional Context
Report https://discuss.flarum.org/d/17771-friendsofflarum-secure-https/29

The cache rules in the officially recommended nginx configuration may causes api route to fail.

There is 404 error when the https proxy is enabled and using the recommended nginx configuration.

I am confused about this issue and cannot understand how the problem is caused.