frojd / frojd-jewl Goto Github PK

Is the popup-component finished? It seems to be the same as Accordion.

There should be an overlay for Navigation Drawer when expanded, as when doing a modal popup.
Tabbing should be focused inside the menu, not reach links or other elements outside.

https://ariakit.org/

It's tree shakable (good for performance) and good accessibility wise, and (relatively) easy to style.

The contrast value between active and hover-state is not sufficient to pass. We should be able to write a function that generates a more accessible color? Maybe something similar to this: https://css-tricks.com/programming-sass-to-create-accessible-color-combinations/

According to facebook/react#16210 defaultProps on functional components are deprecated and will be removed in a feature version of React. defaultProps should instead replaced with default values on arguments.

Quick example:

Functional component with defaultProps should go from this:

const Accordion = ({title, text, open, id}) => {
    ...
    
Accordion.defaultProps = {
    title: '',
    text: '',
    open: false,
    id: 'accordion',
};

to this:

const Accordion = ({title = '', text = '', open = false, id = 'accordion'}) => {
    ...

Textlink and Textlink White have different hover-states, they should be the same but inverted. I am not sure what the correct version is, but Textlink White loses border bottom on hover.

Skip-to-content is regularly used by users who can't navigate/scroll an entire page looking for content. When doing information heavy sites, it can be really useful.

https://www.w3.org/WAI/GL/WCAG20-TECHS/G1.html

See reference: https://www.svt.se/