fromkeith / fine-uploader Goto Github PK

Type of issue [REQUIRED]

Bug

Uploader type [REQUIRED]

S3

Bug details

Fine Uploader version [REQUIRED]

own branch. (fix-3)
However, the error stack is the same as what is in develop.

Browsers where the bug is reproducible [REQUIRED]

Chrome (but should apply to all)

Operating systems where the bug is reproducible [REQUIRED]

Windows 10 (but should apply to all)

Exact steps required to reproduce the issue [REQUIRED]

For example:

1. Start multipart upload to s3. (v4)
2. Part way through have your internet connection gets reset
3. Error thrown from qq.s3.util.getCredentialsDate because the input date is undefined.

All of your Fine Uploader initialization JavaScript code [REQUIRED]

new qq.s3.FineUploaderBasic({
    core: {
        maxConnections: 2
    },
    request: {
        endpoint: 'http://my-endpoint',
        accessKey: 'my-access-key'
    },
    signature: {
        endpoint: 'https://my-endpoint',
        version: 4,
        useWorker: true
    },
    retry: {
        enableAuto: true,
        maxAutoAttempts: 3,
        autoAttemptDelay: 2
    },
    chunking: {
        enabled: true,
        concurrent: {
            enabled: true
        }
    },
    cors: {
        expected: true
    },
    objectProperties: {
        region: 'some-region',
        bucket: 'somebucket',
        key(fileId) {
            var file = uploader.getFile(fileId);
            return file.s3key;
        }
    },
    callbacks: {
        onSubmit(fileId, fileName) {
            // determine proper id and return promise.
        },
        onAutoRetry(fileId, fileName, attemptNumber) {
            // ui stuff
        },
        onManualRetry(fileId, fileName) {
            // ui stuff
        },
        onProgress(fileId, fileName, uploadBytes, totalBytes) {
            // record progress
        },
        onComplete(fileId, fileName, responseJson, xhr) {
            // do ui stuff
        },
        onError() {
            // do ui stuff and manual rety stuff
        },
        onCancel() {
            // do ui stuff
        }
    }
});

Detailed explanation of the problem [REQUIRED]

Here's what I think is happening, but haven't written to the code to test it yet.

1. request-signer.js::getStringToSignArtifacts call fails to my server. The connection was reset. So the status is 0 and all the promises get rejected.
2. We then retry the upload/signing.
3. So request-signer.js::generateHeaders will try to create the authorization string.
4. This calls signatureConstructor.getRequestDate
5. However, since the request-signer.js::getStringToSignArtifacts failed, the "artifacts" object is undefined.
6. Thus getRequestDate returns undefined.
7. That is passed to qq.s3.util.getCredentialsDate resulting in the error thrown.

I will look into a fix for this.. just wanted to document it so I can come back to it later. And not forget what I think the stack was.

Thanks!