frontend / toolbox Goto Github PK

We've got some work to do!

http://www.zell-weekeat.com/responsive-typography

cc @guillaumeberry 😉

Add me to: https://github.com/frontend
Thank you!

Toolbox is only compatible Node 8+. It crash on earlier version, please notice it on the documentation !

If you use an other version you will get the following error:

$ toolbox build
/Users/wengerk/www/quartiers-solidaires/node_modules/toolbox-utils/index.js:15
);
^
SyntaxError: Unexpected token )

• Missing documentation about usage of builded files (and which file(s) will be builded)
• Missing documentation about usage of toolbox.json

These are very nice features and can have much value for the customer. A line about them in the doc might be nice :D

Think a way to add a configurable way to include handlebars helper to provide some essential features like modulo condition 😆

The last line in twig files mnust be empty. Editorconfig will do that automatically. We strip the last line when rendering in toolbox-reader: frontend/toolbox-reader#9 (comment)

When reaching https://frontend.github.io/toolbox, it's broken (seems every files are loaded with http).

I joyfully set up the multiple Webpack bundles configuration like this:

  "bundles": {
    "js": [
      {
        "name": "credit",
        "src": "web/themes/wd/assets/components/molecules/credit/credit.js"
      },
      {
        "name": "app",
        "src": "web/themes/wd/assets/components/base.js"
      }
    ]
  }

And the build doesn't crash anything and just continues building the app bundle as if nothing was wrong.

I should have written a path relative to the src value:

  "bundles": {
    "js": [
      {
        "name": "credit",
        "src": "components/molecules/credit/credit.js"
      },
      {
        "name": "app",
        "src": "components/base.js"
      }
    ]
  }

Since all the paths in toolbox.json are written from the project root, I never imagined that was the wrong thing to do:

  "images": [
    "web/themes/wd/build/images/**/*"
  ],

So, we should either keep it like this (and then document why the path is relative to src), or change this to be consistent with the rest of the config. Cheers!