froog / silvergraph Goto Github PK

Hi, your module made me aware of Graphviz as a way to visualize structural data, thanks for this!

I am now using dot to visualise workflows in a (yet unpublished) workflows-module, so for this dot needs to be installed on the live server.

As it can be quite hard to get Graphviz/dot installed on a server if you don't have admin permissions, I've published a pre-compiled version which you can just upload and use via FTP. It may be nice to add this to your README and/or suggest it when installing via composer?

https://github.com/restruct/dot-static/

I'm using this as part of reviewing the structure for the shop module, so I'm wanting this url to create a diagram of only the shop module: /Silvergraph/png?location=shop.
It does however include all modules that contain shop in their name, notably shop_shipping.

This is what I'd expect:

This is what I get:

This module doesn't work out-of-the-box with SilverStripe 3.2.
Firstly you need to add the controller, due to URL routing by controller name having been removed.

This could be done like this:

Director:
  rules:
    'Silvergraph//$Action' : 'Silvergraph'

Secondly the graph looks to be messed up, see this example for /Silvergraph/png?location=mysite,cms&inherited=1&exclude=SiteTree:

@froog as you know, I love your module. I'm just missing one thing - $many_many_extraFields are not shown - do you think it would be a big thing to implement?

I think it would be beneficial if certain class attributes could be hidden from a table.
See Member here, if we could hide all the hash items etc. that would make the model easier to read.

I think that should be configurable in the query string just like you can do with tables now (&exclude=SiteTree,Page). The format could be something like &excludeAttributes=Member[TempIDHash,TempIDExpired].

Hey

When trying to run SilverGraph/png, it throws "Couldn't execute dot command, ensure graphviz is installed and 'dot' postpended to your graphviz path. See README.md. Shell error: sh: dot: command not found"

It does work however, if I manually enter the path to the dot exec, in the execute() method, instead of it being retrieved from a constant.

I have no idea why though, just thought I'd make you aware of it

I'm getting a syntax error back from dot (graphviz version 2.34.0 (20131025.1914)):

[User Notice] Couldn't execute dot command, ensure graphviz is installed and dot is on path. Shell error: Warning: :1: syntax error in line 1 near '>'

This is from running in the browser /Silvergraph/png

This is Mac OS X with graphviz installed via homebrew. I've checked that dot is in the PHP PATH environment variable.

When running the above command when logged in, I was receiving the following error:
Couldn't execute dot command, ensure graphviz is installed and dot is on path.

After some digging I narrowed the issue down to the <b> and </b> tags in line 20 of the Silvergraph.ss template. After removing them everything worked fine.

Do you think this worth a pull request, or does this seem like it is an issue with my installations on my server?