Giter VIP home page Giter VIP logo

Comments (5)

tpetricek avatar tpetricek commented on July 20, 2024

I included fix from @soloman817 (in the PowerPack code) that filtered out some private members, but I'm not sure if that fixed this issue too. Can you please check?

from fsharp.formatting.

soloman817 avatar soloman817 commented on July 20, 2024

@forki @tpetricek I can see from your screenshot that you might not use the newest one, because in newest source, the name shouldn't include the type name, it would be GetParams, not Shell.GetParams. So I suggest:

  1. use the newest one of fsformatting.
  2. verify the output name, to see if it is newest one.
  3. if the problem still exists, please clone https://github.com/soloman817/FSharpPowerPack and then build only the FSharpPowerPack.Metadata, and then copy the built dll to override the one that shipped with fsformatting.

from fsharp.formatting.

tpetricek avatar tpetricek commented on July 20, 2024

BTW: @soloman817 I included your version of FSharpPowerPack in the src directory of FSharp.Formatting, so that we can maintain this project here (I doubt anyone else will need it). I'll include it in a new NuGet package (building now)

from fsharp.formatting.

soloman817 avatar soloman817 commented on July 20, 2024

@tpetricek yes, I just pushed your repo to my repo, and checked the commits, and see that you included the metadata. This is good.

from fsharp.formatting.

matthid avatar matthid commented on July 20, 2024

I'm pretty sure we now properly filter out private stuff when publicOnly is set to true. Please comment if this is still not working.

from fsharp.formatting.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.