Giter VIP home page Giter VIP logo

Comments (4)

ap-- avatar ap-- commented on July 17, 2024

Hi @joouha

Currently we throw away query and fragments here:

args_list.insert(0, parsed_url.path)

But since only the first argument to UPath is parsed, there's one way to construct the path right now.

>>> upath.UPath("http://example.com/a")
HTTPPath('http://example.com/a')

>>> upath.UPath("http://example.com/", "a?q=123")
HTTPPath('http://example.com/a?q=123')

but joining on this doesn't work correctly, since it just treats it like a filename.

I think the correct way to fix this is adding query and fragment in

def _format_parsed_parts(
if they are present.

And then there needs to be some code that updates query and fragments whenever we join paths.
(to do joins correctly this will also require fixing #88)

Would you like to work on a PR?
I'll only have time to work on this in about 2-3 weeks from now.

Cheers,
Andreas

from universal_pathlib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.