fujiwara / aws-xray Goto Github PK

AWS X-Ray segment names "can contain Unicode letters, numbers, and whitespace, and the following symbols: _, ., :, /, %, &, #, =, +, , -, @" ("Segment Fields", in "Segment Documents"

capture() does not presently enforce this restriction, causing segments with names that do not follow the rule to be rejected by AWS. I suggest that capture() should die when it receives an invalid segment name.

When we use capture() inside a Lambda function, the $AWS::XRay::SEGMENT_ID is set with the correct segment ID (code).

But when a new segment is created, if that variable is present and set, the subsegment namespace is always set to remote (code).

This causes the Trace histogram in the console to look "weird", as if our capture() calls were remote calls, which most of them were not.

I think it is important to distinguish between capture() for remote calls and just plain segments that we want to time and trace properly.

I'm not sure how to go about it, but I think that either making trace() different from capture() and not setting namespace to remote when trace() is used, or adding a new subsegment() call, one of them should work.

Opinions?

AWS X-Ray segment names "can contain Unicode letters, numbers, and whitespace, and the following symbols: _, ., :, /, %, &, #, =, +, , -, @" ("Segment Fields", in "Segment Documents"

capture() does not presently enforce this restriction, causing segments with names that do not follow the rule to be rejected by AWS. I suggest that capture() should die when it receives an invalid segment name.

On some of my smoker systems the test is failing:

#   Failed test at t/09_plugin.t line 25.
#     Structures begin differing at:
#          $got->{ec2}{instance_id} = '967348'
#     $expected->{ec2}{instance_id} = ''
# Looks like you failed 1 test of 2.
t/09_plugin.t .......... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/2 subtests