fukamachi / anypool Goto Github PK

View Code? Open in Web Editor NEW

23.0 4.0 3.0 38 KB

General-purpose connection pooling library for Common Lisp

License: BSD 2-Clause "Simplified" License

Common Lisp 96.30% Makefile 1.33% Dockerfile 2.37%

common-lisp connection-pool

anypool's People

Contributors

Stargazers

Watchers

Forkers

salewski tevo45

anypool's Issues

Failure with queue-underflow-error condition.

I modified idle-timeout unittest to many time fetch and putback.
And I executed unittest using make command.

diff --git a/tests/main.lisp b/tests/main.lisp
index bdc7962..00c4a83 100644
--- a/tests/main.lisp
+++ b/tests/main.lisp
@@ -120,7 +120,7 @@
                         collect (bt:make-thread
                                  (lambda ()
                                    (loop
-                                     repeat 1000
+                                     repeat 1000000
                                      do (let ((object (fetch pool)))
                                           (putback object pool))))))))
     (dolist (thread threads)

It failed with cl-speedy-queue:queue-underflow-error every time.

Unhandled CL-SPEEDY-QUEUE::QUEUE-UNDERFLOW-ERROR in thread #<SB-THREAD:THREAD tid=32 "Anonymous thread" RUNNING
                                                              {1002572553}>:
  Queue #(8 8
          #S(ANYPOOL::ITEM
             :OBJECT 28075270
             :IDLE-TIMER #<TIMER {1001BC03B3}>
             :ACTIVE-P T
             :TIMEOUT-P NIL)
          #S(ANYPOOL::ITEM
             :OBJECT 28075270
             :IDLE-TIMER #<TIMER {1001BC0553}>
             :ACTIVE-P T
             :TIMEOUT-P NIL)
          #S(ANYPOOL::ITEM
             :OBJECT 28075270
             :IDLE-TIMER #<TIMER {1001BC06F3}>
             :ACTIVE-P T
             :TIMEOUT-P NIL)
          #S(ANYPOOL::ITEM
             :OBJECT 28075270
             :IDLE-TIMER #<TIMER {1001BC0893}>
             :ACTIVE-P T
             :TIMEOUT-P NIL)
          #S(ANYPOOL::ITEM
             :OBJECT 28075270
             :IDLE-TIMER #<TIMER {1001BC0A33}>
             :ACTIVE-P NIL
             :TIMEOUT-P NIL)
          #S(ANYPOOL::ITEM
             :OBJECT 2004227
             :IDLE-TIMER #<TIMER {1001BD8213}>
             :ACTIVE-P T
             :TIMEOUT-P NIL)
          #:EMPTY
          #S(ANYPOOL::ITEM
             :OBJECT 28075270
             :IDLE-TIMER #<TIMER {1001BC8073}>
             :ACTIVE-P T
             :TIMEOUT-P NIL)
          #S(ANYPOOL::ITEM
             :OBJECT 2004227
             :IDLE-TIMER #<TIMER {1001BC8213}>
             :ACTIVE-P T
             :TIMEOUT-P NIL)
          #S(ANYPOOL::ITEM
             :OBJECT 13969607
             :IDLE-TIMER #<TIMER {1001B380D3}>
             :ACTIVE-P NIL
             :TIMEOUT-P NIL)
          #S(ANYPOOL::ITEM
             :OBJECT 2004227
             :IDLE-TIMER #<TIMER {1001B38273}>
             :ACTIVE-P T
             :TIMEOUT-P NIL)
          #S(ANYPOOL::ITEM
             :OBJECT 27111155
             :IDLE-TIMER #<TIMER {1001BD0073}>
             :ACTIVE-P NIL
             :TIMEOUT-P NIL)
          #S(ANYPOOL::ITEM
             :OBJECT 2004227
             :IDLE-TIMER #<TIMER {1001BD0213}>
             :ACTIVE-P T
             :TIMEOUT-P NIL)
          #S(ANYPOOL::ITEM
             :OBJECT 6340723
             :IDLE-TIMER #<TIMER {1001BD8073}>
             :ACTIVE-P T
             :TIMEOUT-P NIL)
          #S(ANYPOOL::ITEM
             :OBJECT 31615694
             :IDLE-TIMER #<TIMER {1001BE0073}>
             :ACTIVE-P NIL
             :TIMEOUT-P NIL)
          #S(ANYPOOL::ITEM
             :OBJECT 6340723
             :IDLE-TIMER #<TIMER {1001BE0213}>
             :ACTIVE-P NIL
             :TIMEOUT-P NIL)
          #S(ANYPOOL::ITEM
             :OBJECT 28075270
             :IDLE-TIMER #<TIMER {1001BE8073}>
             :ACTIVE-P T
             :TIMEOUT-P NIL)
          #S(ANYPOOL::ITEM
             :OBJECT 34192003
             :IDLE-TIMER #<TIMER {1001BF0073}>
             :ACTIVE-P NIL
             :TIMEOUT-P NIL)
          #S(ANYPOOL::ITEM
             :OBJECT 28075270
             :IDLE-TIMER #<TIMER {1001BF0213}>
             :ACTIVE-P T
             :TIMEOUT-P NIL)
          #S(ANYPOOL::ITEM
             :OBJECT 31615694
             :IDLE-TIMER #<TIMER {1001BC0213}>
             :ACTIVE-P NIL
             :TIMEOUT-P NIL)) is empty, and can't be dequeued anymore

Backtrace for: #<SB-THREAD:THREAD tid=32 "Anonymous thread" RUNNING {1002572553}>
0: (SB-DEBUG::DEBUGGER-DISABLED-HOOK #<CL-SPEEDY-QUEUE::QUEUE-UNDERFLOW-ERROR {1001BA8663}> #<unused argument> :QUIT T)
1: (SB-DEBUG::RUN-HOOK *INVOKE-DEBUGGER-HOOK* #<CL-SPEEDY-QUEUE::QUEUE-UNDERFLOW-ERROR {1001BA8663}>)
2: (INVOKE-DEBUGGER #<CL-SPEEDY-QUEUE::QUEUE-UNDERFLOW-ERROR {1001BA8663}>)
3: (ERROR CL-SPEEDY-QUEUE::QUEUE-UNDERFLOW-ERROR :QUEUE #(8 8 #S(ANYPOOL::ITEM :OBJECT 28075270 :IDLE-TIMER #<TIMER {1001BC03B3}> :ACTIVE-P T :TIMEOUT-P NIL) #S(ANYPOOL::ITEM :OBJECT 28075270 :IDLE-TIMER #<TIMER {1001BC0553}> :ACTIVE-P T :TIMEOUT-P NIL) #S(ANYPOOL::ITEM :OBJECT 28075270 :IDLE-TIMER #<TIMER {1001BC06F3}> :ACTIVE-P T :TIMEOUT-P NIL) #S(ANYPOOL::ITEM :OBJECT 28075270 :IDLE-TIMER #<TIMER {1001BC0893}> :ACTIVE-P T :TIMEOUT-P NIL) #S(ANYPOOL::ITEM :OBJECT 28075270 :IDLE-TIMER #<TIMER {1001BC0A33}> :ACTIVE-P NIL :TIMEOUT-P NIL) #S(ANYPOOL::ITEM :OBJECT 2004227 :IDLE-TIMER #<TIMER {1001BD8213}> :ACTIVE-P T :TIMEOUT-P NIL) #:EMPTY #S(ANYPOOL::ITEM :OBJECT 28075270 :IDLE-TIMER #<TIMER {1001BC8073}> :ACTIVE-P T :TIMEOUT-P NIL) #S(ANYPOOL::ITEM :OBJECT 2004227 :IDLE-TIMER #<TIMER {1001BC8213}> :ACTIVE-P T :TIMEOUT-P NIL) #S(ANYPOOL::ITEM :OBJECT 13969607 :IDLE-TIMER #<TIMER {1001B380D3}> :ACTIVE-P NIL :TIMEOUT-P NIL) ...))
4: (CL-SPEEDY-QUEUE:DEQUEUE #(8 8 #S(ANYPOOL::ITEM :OBJECT 28075270 :IDLE-TIMER #<TIMER {1001BC03B3}> :ACTIVE-P T :TIMEOUT-P NIL) #S(ANYPOOL::ITEM :OBJECT 28075270 :IDLE-TIMER #<TIMER {1001BC0553}> :ACTIVE-P T :TIMEOUT-P NIL) #S(ANYPOOL::ITEM :OBJECT 28075270 :IDLE-TIMER #<TIMER {1001BC06F3}> :ACTIVE-P T :TIMEOUT-P NIL) #S(ANYPOOL::ITEM :OBJECT 28075270 :IDLE-TIMER #<TIMER {1001BC0893}> :ACTIVE-P T :TIMEOUT-P NIL) #S(ANYPOOL::ITEM :OBJECT 28075270 :IDLE-TIMER #<TIMER {1001BC0A33}> :ACTIVE-P NIL :TIMEOUT-P NIL) #S(ANYPOOL::ITEM :OBJECT 2004227 :IDLE-TIMER #<TIMER {1001BD8213}> :ACTIVE-P T :TIMEOUT-P NIL) #:EMPTY #S(ANYPOOL::ITEM :OBJECT 28075270 :IDLE-TIMER #<TIMER {1001BC8073}> :ACTIVE-P T :TIMEOUT-P NIL) #S(ANYPOOL::ITEM :OBJECT 2004227 :IDLE-TIMER #<TIMER {1001BC8213}> :ACTIVE-P T :TIMEOUT-P NIL) #S(ANYPOOL::ITEM :OBJECT 13969607 :IDLE-TIMER #<TIMER {1001B380D3}> :ACTIVE-P NIL :TIMEOUT-P NIL) ...))
5: ((FLET SB-THREAD::WITH-MUTEX-THUNK :IN ANYPOOL:FETCH))
6: ((FLET "WITHOUT-INTERRUPTS-BODY-1" :IN SB-THREAD::CALL-WITH-MUTEX))
7: (SB-THREAD::CALL-WITH-MUTEX #<FUNCTION (FLET SB-THREAD::WITH-MUTEX-THUNK :IN ANYPOOL:FETCH) {7F91337765FB}> #<SB-THREAD:MUTEX "ANYPOOL-LOCK" contested owner=Anonymous thread> T NIL)
8: (ANYPOOL:FETCH #<ANYPOOL:POOL "test pool" (OPEN=2 / IDLE=-2) {1002571B03}>)
9: ((LAMBDA NIL :IN "/app/tests/main.lisp"))
10: ((LABELS BORDEAUX-THREADS::%BINDING-DEFAULT-SPECIALS-WRAPPER :IN BORDEAUX-THREADS::BINDING-DEFAULT-SPECIALS))
11: ((FLET SB-UNIX::BODY :IN SB-THREAD::RUN))
12: ((FLET "WITHOUT-INTERRUPTS-BODY-156" :IN SB-THREAD::RUN))
13: ((FLET SB-UNIX::BODY :IN SB-THREAD::RUN))
14: ((FLET "WITHOUT-INTERRUPTS-BODY-149" :IN SB-THREAD::RUN))
15: (SB-THREAD::RUN)
16: ("foreign function: call_into_lisp_")
17: ("foreign function: funcall1")

unhandled condition in --disable-debugger mode, quitting

Tests fails on macOS under SBCL-2.3.11

;; testing 'anypool/tests'
make-pool
  ✓ Expect POOL to be an instance of POOL.
  ✓ Expect (POOL-MAX-OPEN-COUNT POOL) to be an instance of FIXNUM.
  ✓ Expect (POOL-MAX-IDLE-COUNT POOL) to be an instance of FIXNUM.
  ✓ Expect (= (POOL-OPEN-COUNT POOL) 0) to be true.
  ✓ Expect (= (POOL-ACTIVE-COUNT POOL) 0) to be true.
  ✓ Expect (= (POOL-IDLE-COUNT POOL) 0) to be true.
fetch-and-putback
  'fetch' can allocate a new object
    ✓ Expect (STRING= (FIRST ACTIVE-OBJECTS) "dummy1") to be true.
    ✓ Expect (= (POOL-OPEN-COUNT POOL) 1) to be true.
    ✓ Expect (= (POOL-ACTIVE-COUNT POOL) 1) to be true.
    ✓ Expect (= (POOL-IDLE-COUNT POOL) 0) to be true.
    ✓ Expect (STRING= (FIRST ACTIVE-OBJECTS) "dummy2") to be true.
    ✓ Expect (= (POOL-OPEN-COUNT POOL) 2) to be true.
    ✓ Expect (= (POOL-ACTIVE-COUNT POOL) 2) to be true.
    ✓ Expect (= (POOL-IDLE-COUNT POOL) 0) to be true.
  'fetch' can't allocate exceeding the max-open-count
    ✓ Expect (FETCH POOL) to signal TOO-MANY-OPEN-CONNECTION.
    ✓ Expect (= (POOL-OPEN-COUNT POOL) 2) to be true.
    ✓ Expect (= (POOL-ACTIVE-COUNT POOL) 2) to be true.
    ✓ Expect (= (POOL-IDLE-COUNT POOL) 0) to be true.
  'putback' can return a fetched object back
    × 0) Raise an error while testing.
  'putback' disallocates an idle object exceeding max-idle-count
    ✓ Expect (= (POOL-OPEN-COUNT POOL) 1) to be true.
    ✓ Expect (= (POOL-ACTIVE-COUNT POOL) 0) to be true.
    ✓ Expect (= (POOL-IDLE-COUNT POOL) 1) to be true.
ping
  × 1) Raise an error while testing.
idle-timeout
  - :idle-timeout works only on SBCL
timeout
  ✓ Expect (= (POOL-OPEN-COUNT POOL) 2) to be true.
  ✓ Expect (FETCH POOL) to be true. (100ms)

Condition of type: SIMPLE-ERROR
Attempted to give up lock #<lock (nonrecursive) "ANYPOOL-LOCK" 0x10e7c8de0> that is not owned by process #<process "Unknown thread 0" 0x10d9299a0>
Available restarts:

1. (ABORT) ABORT

Top level in: #<process Unknown thread 0 0x10d9299a0>.
> 
  × 2) Expect (FETCH POOL) to signal TOO-MANY-OPEN-CONNECTION.
disable-pooling
  ✓ Expect (= (POOL-OPEN-COUNT POOL) 1) to be true.
  ✓ Expect (= (POOL-IDLE-COUNT POOL) 0) to be true.
  × 3) Raise an error while testing.

× 1 of 1 test failed

0) anypool/tests
     › FETCH-AND-PUTBACK
       › NIL

   Raise an error while testing.
   SIMPLE-ERROR: Attempted to give up lock #<lock (nonrecursive) "ANYPOOL-LOCK" 0x10e6dd7e0> that is not owned by process #<process SI:TOP-LEVEL 0x10c91eee0>

     0: (SI:BYTECODES)
     1: (SI:BYTECODES NIL NIL NIL NIL NIL NIL T)
     2: (SI:BYTECODES)

1) anypool/tests
     › FETCH-AND-PUTBACK
       › NIL

   Expect (EQUAL
           (ROVE/CORE/ASSERTION::OUTPUT-OF (PUTBACK (POP ACTIVE-OBJECTS) POOL)
                                           *STANDARD-OUTPUT*)
           "disallocated dummy1") to be true.
   SIMPLE-ERROR: Attempted to give up lock #<lock (nonrecursive) "ANYPOOL-LOCK" 0x10e6dd7e0> that is not owned by process #<process SI:TOP-LEVEL 0x10c91eee0>
     (ROVE/CORE/ASSERTION:OUTPUTS
      #1=(ANYPOOL:PUTBACK (POP ANYPOOL/TESTS::ACTIVE-OBJECTS) ANYPOOL:POOL)
      "disallocated dummy1")
     (EQUAL (ROVE/CORE/ASSERTION::OUTPUT-OF #1# *STANDARD-OUTPUT*)
            "disallocated dummy1")

     0: (SI:BYTECODES)
     1: (SI:BYTECODES NIL NIL NIL NIL NIL NIL T)
     2: (SI:BYTECODES)

2) anypool/tests
     › PING

   Raise an error while testing.
   SIMPLE-ERROR: Attempted to give up lock #<lock (nonrecursive) "ANYPOOL-LOCK" 0x10e6dd000> that is not owned by process #<process SI:TOP-LEVEL 0x10c91eee0>

     0: (SI:BYTECODES)
     1: (SI:BYTECODES NIL NIL NIL NIL NIL NIL T)
     2: (SI:BYTECODES)

3) anypool/tests
     › TIMEOUT

   Expect (FETCH POOL) to signal TOO-MANY-OPEN-CONNECTION.
   SIMPLE-ERROR: Attempted to give up lock #<lock (nonrecursive) "ANYPOOL-OPENWAIT-LOCK" 0x10e7c8d80> that is not owned by process #<process SI:TOP-LEVEL 0x10c91eee0>
     (ROVE/CORE/ASSERTION:SIGNALS (ANYPOOL:FETCH ANYPOOL:POOL)
                                  'ANYPOOL:TOO-MANY-OPEN-CONNECTION)

     0: (SI:BYTECODES)
     1: (SI:BYTECODES NIL NIL NIL NIL NIL NIL T)
     2: (SI:BYTECODES)

4) anypool/tests
     › DISABLE-POOLING

   Raise an error while testing.
   SIMPLE-ERROR: Attempted to give up lock #<lock (nonrecursive) "ANYPOOL-LOCK" 0x10e7c8b40> that is not owned by process #<process SI:TOP-LEVEL 0x10c91eee0>

     0: (SI:BYTECODES)
     1: (SI:BYTECODES NIL NIL NIL NIL NIL NIL T)
     2: (SI:BYTECODES)

Summary:
  1 test failed.
    - anypool/tests

Wait when no resource is available for `:timeout nil` instead of raising a condition

ref #1 (comment)

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.