fuko-php / masked Goto Github PK

Hi. I've scrutinized your code and have notice several code block with similar code. For instance:

This method hides values from array https://github.com/fuko-php/masked/blob/master/src/Protect.php#L44 and you have also method hideValue that does the same work.
And your hideValues could look like this

public static function hideValues(array $values)
{
   foreach ($values as $value){
      self::hideValue($value);
   }
}

The same problem also is here: https://github.com/fuko-php/masked/blob/master/src/Protect.php#L185

foreach ($names as $name)
{
   self::hideInput($name, $type);
}

If the sensitive data contains special chars, in some occasions they are going to be escaped, and Protect::protectScalar() is not going to detect them. For example quotes in JSON

echo json_encode('password"'); // output is "password\""

Detecting credit card numbers is relatively easy. It will be a great addition if they are detected as sensitive data without any declaration and properly masked/redacted

the use of FILTER_SANITIZE_STRING is deprecated since PHP 8.1.0.

this is used twice in fuko-php/masked/src/Masked/Redact.php on line 107 and 109.

the use of htmlspecialchars() instead is encouraged.

This needs to be updated in the code.

Unfortunately, not PHP8 compatible. Pls, mark is as abandoned.