fulcrologic / fulcro-developer-guide Goto Github PK

The example for dynamic queries appears to be broken (example no. 39 -http://book.fulcrologic.com/#DynamicQueries).

Expected behaviour: when clicking "Add :y to query" the display changes to y: 99.
Actual behaviour: when clicking "Add :y to query" the display remains at y: (blank).

Examples containing text areas and tables are either exploding or not filling well the div

This is a minor issue, the code example above the line:

If you now reload your page you should see two headings, but no people.

would create double labels, one h3 in Root and one h4 in PersonList.

In the 3.9.1 Automatic Normalization section, the step The callback can now delete people by their ID, which is more reliable. refers to two lines of code that are implemented in the 3.9.2 Mutations on a Normalized Database section. Should the steps or code sample be updated?

E.g. in http://book.fulcrologic.com/fulcro3/#_install_fulcro_inspect, where there is an <img src="assets/img/inspect-open.png" alt="inspect open">. Replacing it with <img src="/assets/img/inspect-open.png" alt="inspect open"> fixes it. Sorry, I'm not sure how to fix it in the .adoc file, otherwise I'd submit a PR.

http://book.fulcrologic.com/#SharedState

Looks like reconciler-options was removed in the move to version 3. Also, make-fulcro-client was changed to fulcro-app, I think. I will create a PR when I better understand the change. Maybe it's as simple as renaming make-fulcro-client and removing reconciler-options and un-nesting the shared/shared-fn.

Looks like a fantastic book. it's more more than a clojure-specific take on web-development using a nascent framework ... it seems to be a book that covers the bases for generalist webdevelopment, providing solutions in Fulcro/React/Clojure. (i would like to buy it)

Kudos!

In Section 4.4.1, I think [:person/by-id 4] should be [:person/id 4].