fullstack-hy2020 / part3-notes-backend Goto Github PK

Description of the problem

• Error - Terminal throw an error : “ Cannot set headers after they are sent to the client ” when i use GET method to get a note
• Solution - delete response.json(note)
• Screenshot of the error

1. Postman
2. Terminal

// Error Code
app.get('/api/notes/:id', (request, response) => {
  const id = Number(request.params.id)
  const note = notes.find(note => note.id === id)

  if (note) {
    response.json(note)
  } else {
    response.status(404).end()
  }
// delete this line
  response.json(note)
})

// Solution 
app.get('/api/notes/:id', (request, response) => {
  const id = Number(request.params.id)
  const note = notes.find(note => note.id === id)

  if (note) {
    response.json(note)
  } 

  if(!note){
    response.status(404).end()
  }
})

Reproduction Repo:

null

Node Version:

v16.19.1

Platform and Version:

win 11 22H2

Other

Good morning, teacher
I am a JavaScript learner from China，thanks for your open source projects and translate it in chinese，I gain a lot. that why I yearn for your university. however, I didn't study hard in college，my GPA is low now, so I can't apply to your university. this is my first official writing issue，if there are any problems, please point them out and provide information in the correct format, I will modify it next time. If you come to Hang Zhou（Zhe Jiang） to play，I will welcome you warmly.
Yours
China student
2023.5.10

Is it better to put the close database operation in Promise finally？

Person
.find({})
.then(persons=> {
// ...
mongoose.connection.close()
})

Vite build in a directory named "dist"

Need to change the build:ui script in all branches from :
"build:ui": "rm -rf build && cd ../frontend/ && npm run build && cp -r build ../backend"
into :
"build:ui": "rm -rf dist && cd ../frontend/ && npm run build && cp -r dist ../backend",

Hi! Thanks for the great course

In this section we deploy our notes app to the internet:

https://fullstackopen.com/en/part3/deploying_app_to_internet

At this point however, the notes app has a bug. There is no PUT endpoint declared, and as a result whenever the user presses the 'make (not) important' button, it simply deletes the note

I can't see db.json content using a new path in the baseUrl variable, the last path was '/notes', then we need to change it to '/api/notes', but with this url path I can't see the content.

I already visited the '/api/notes' url and only shows and empty object.
If I visit the last url '/notes' I can see them...

How to solve this problem?

Please create a ReadMe file with short texts about the project and each branches.
Some basic commands regarding git and npm.

I would like to add one if assigned.

this part from part4, User administration, Creating a new note made me really confused. I ended up just skipping it.:

The note scheme will also need to change as follows in our models/note.js file:

const noteSchema = new mongoose.Schema({
  content: {
    type: String,
    minLength: 5,
    required: true,
  },
  important: Boolean,
  user: String,})

Maybe I didnt understand something important or maybe this is worth looking over why this part is here?