funsol-projects / funsol-billing-helper Goto Github PK

Subscriptions are still processed even when an empty subscription list is provided to the library, resulting in the following error:

Fatal Exception: java.lang.IllegalArgumentException
Product list cannot be empty.
com.android.billingclient.api.QueryProductDetailsParams$Builder.setProductList (com.android.billingclient:billing@@7.0.0:2)
com.funsol.iap.billing.FunSolBillingHelper.fetchAvailableAllSubsProducts (FunSolBillingHelper.kt:200)
com.funsol.iap.billing.FunSolBillingHelper.access$fetchAvailableAllSubsProducts (FunSolBillingHelper.kt:19)
com.funsol.iap.billing.FunSolBillingHelper$startConnection$1$onBillingSetupFinished$1$1.invokeSuspend (FunSolBillingHelper.kt:140)
kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith (ContinuationImpl.kt:33)
kotlinx.coroutines.DispatchedTask.run (DispatchedTask.kt:106)
kotlinx.coroutines.internal.LimitedDispatcher$Worker.run (LimitedDispatcher.kt:115)
kotlinx.coroutines.scheduling.TaskImpl.run (Tasks.kt:100)
kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely (CoroutineScheduler.kt:584)
kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask (CoroutineScheduler.kt:793)
kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker (CoroutineScheduler.kt:697)
kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run (CoroutineScheduler.kt:684)

Thank you for providing such an excellent project as FunSolBillingHelper. However, I have a few questions. Running the original project for the first time continuously results in billingClient being not null. This prevents startConnection() from being called in subsequent runs, making it impossible to call fetchAvailableAllSubsProducts(subKeys), resulting in a PRODUCT_NOT_EXIST error every time a purchase is attempted. To address this, I made a slight modification:

1. I added billingClient = null in FunSolBillingHelper(this).release(), and called FunSolBillingHelper(this).release() in onDestroy(). However, this seems to be ineffective.
2. I called FunSolBillingHelper(this).release() directly before FunSolBillingHelper(this).setSubKeys..... This worked, and I was able to successfully initiate payments every time.

I’m not sure if I have misunderstood your code, so I hope you can review it. If you think it’s appropriate, I am willing to submit a Pull Request.