furtif / pogoprotos Goto Github PK

Seeing duplicate object when parsing the proto file. I get this on raw_protos.proto but not in base.proto. Just started with this version.

[
  Error: duplicate name 'GenerateGmapSignedUrlOutProto' in Namespace .DumpProtos
      at Namespace.add (...\node_modules\protobufjs\src\namespace.js:239:23)      
      at parseType (...\node_modules\protobufjs\src\parse.js:344:16)
      at parseCommon (...\node_modules\protobufjs\src\parse.js:259:17)
      at parse ...\node_modules\protobufjs\src\parse.js:731:21)
      at process (...\node_modules\protobufjs\src\root.js:117:30)
      at ...\node_modules\protobufjs\src\root.js:184:17
      at fetchReadFileCallback ...\Pokebot\node_modules\@protobufjs\fetch\index.js:51:19)
      at FSReqCallback.readFileAfterClose [as oncomplete] (internal/fs/read_file_context.js:63:3)
]

yo, not sure if u even check issues.

anyway, i sometimes crash when decoding a GetHoloInventoryResponse, failing with "throw Error("invalid wire type " + wireType + " at offset " + this.pos);"

im using node.js todo the protobuf stuff.

After debugging it down, i found that i fails on EggIncubator decode, when it tries to read the pokemon id as fixed64 as you have here:

https://github.com/Furtif/POGOProtos/blob/master/src/POGOProtos/Inventory/EggIncubator.proto

The pokemon_id in my case is
uint64: Long { low: -49685929, high: -682833928, unsigned: true } -> 15513994688595614295n
int64: Long { low: -49685929, high: -682833928, unsigned: false } -> -2932749385113937321n

After digging around, i found that many forks in the past also changed it back and forth between fixed64, uint64 or int64.

You changed that somewhere back in 2019, so my question is to why did u change it?
Since for me it seems int64 is correct?

Also if that one is wrong, i guess all the others should be int64 then too, and not fixed64? Or any Idea where the actual problem is, in case fixed64 is correct?

Currently base.proto contains a lot of enums that are not actually part of Holoholo.Rpc, which results in name collisions. For example, CameraZoomInLevel is under namespace Niantic.Holoholo.Combat.Stage and not part of the Rpc namespace. Currently to get around this, we append a prefix to every enum value, which is less than ideal to say the least.

One possible way to resolve this is to dump a root enum only if it is referenced by some IMessage.

I would love to contribute but unfortunately as far as I am concerned the tools for generating the proto are private.

Got this error when using "GetGymDetailsResponse"

String field 'pogoprotos.data.PokemonData.deployed_fort_id' contains invalid UTF-8 data when parsing a protocol buffer. Use the 'bytes' type if you intend to send raw bytes.

Anyone has any idea what went wrong?

Edit:
Sorry, close it. Use the wrong one

Ive looked at what you are doing and I'm so glad someone picked up for the dead repo.

I've been updating https://github.com/celandro/pogoprotos-java for use on https://www.pokebattler.com and https://github.com/BrunnerLivio/pokemongo-game-master for json generation which is used on multiple sites.

I believe that these repos should be linked in the readme (per the pull request on the other repo). The pogoprotos-java might make a good dependency for your java api if you think a minor refactor would be worth it.

Hello Furtif,

I have some questions regarding POGOProtos and POGO itself. Is there any way I could contact you directly?
Discord or Telegram?

Hoping to hear back from you :)

Some versions in base / vx.xxx.x.proto are not compilable

Advice use latest...

And do not ask what is not the most current is because you cannot do everything. The old versions are useless

I need someone to modify https://github.com/Furtif/POGOProtos/blob/master/compile_base.py#L32 ie make a check by tag number and compare change the name to the one used in // ignored_oneof

diffs here: e512ee9

• You can do by number search and by number change the name xxxxxxxx to the one used in OneOfType of one of the names of the same
• This translates to 1/20 of the content
• For the moment they are in mode //ignored_oneof this right obfuscated