fusionbox / django-backupdb Goto Github PK

(I'm creating these issues as note to myself or anybody who wants to work on django-backupdb)

There are 3 packages backupdb, backupdb_utils and unit_tests. This should go in backupdb itself, like backupdb, backupdb.utils, backupdb.tests.

@nolsto discovered that backupdb ignores return codes. Which has been confirmed by @gavinwahl.

(I'm creating these issues as note to myself or anybody who wants to work on django-backupdb)

https://github.com/fusionbox/django-backupdb/blob/e705bb1716520ee4ee52652d7a1572692fb42dd7/unit_tests/ordereddict.py

This is in Django which we depend on

I should be able to specify which connection I want to backup:

$ ./manage.py backupdb --connection=other

(I'm creating these issues as note to myself or anybody who wants to work on django-backupdb)

Once we fix #6, I think we can just use backup.tests to run the tests in setup.py, instead of nose. This way we will be able to remove nose as the tests dependency and remove run_tests.sh and the whole gang of shell scripts.

Downloading/unpacking django-backupdb from https://pypi.python.org/packages/source/d/django-backupdb/django-backupdb-0.5.2.tar.gz#md5=8b0a5331e5e4fa76d6767fa5d3497e7d
  Downloading django-backupdb-0.5.2.tar.gz
  Running setup.py egg_info for package django-backupdb
    warning: no previously-included files matching '*.pyc' found anywhere in distribution

    Installed /XXX/build/django-backupdb/coverage-3.6-py2.7-linux-x86_64.egg

Requirement already up-to-date: django>=1.3 in /XXX/lib/python2.7/site-packages/Django-1.5.2-py2.7.egg (from django-backupdb)
Installing collected packages: django-backupdb
  Found existing installation: django-backupdb 0.4.1f
    Uninstalling django-backupdb:
      Successfully uninstalled django-backupdb
  Running setup.py install for django-backupdb

Successfully installed django-backupdb
Cleaning up...

I don't want to need coverage in order to install backupdb

There are two python packages, backupdb which is the main one with the management commands and so on, and backupdb_utils.

We should put backupdb_utils in backupdb.utils. Is there any reason why there are two packages @davesque ?

(I'm creating these issues as note to myself or anybody who wants to work on django-backupdb)

• django-backupdb/backupdb/management/commands/backupdb.py

  Line 81 in e705bb1

  backup_func = backup_config['backup_func']

• django-backupdb/backupdb/management/commands/backupdb.py

  Line 87 in e705bb1

  if backup_func is do_postgresql_backup:

• django-backupdb/backupdb_utils/settings.py

  Line 13 in e705bb1

  BACKUP_CONFIG = {

• django-backupdb/backupdb_utils/commands.py

  Line 59 in e705bb1

  def get_mysql_args(db_config):

This is kind of nasty. It should use inheritance/polymorphism, and do something like (just the idea):

backend_class = backends[backend_name]
backend = backend_class(**credentials)
backend.do_backup()