fusionbox / django-importcsvadmin Goto Github PK

In the situation of redirects, for example, I would like to validate all of the rows before any are saved. This would allow me to make sure there are no circular redirects. I also think it's good usability not to insert any of them before checking that all of them pass validation.

I was thinking that process_row could become validate_row or even clean_row (then we could also consider it as a hook for fixing some of the data).

Somewhat related:

Also, would it be possible to use form non-field errors instead of the messages framework? I know that it might be a big change, but would it be possible to move the import logic to the Form instead of the View? That would have several advantages:

• We could take the Form in use it outside of the admin in a normal FormView.
• clean_row could live on the form, and be a part of the normal validation flow
• The obvious place to the circular redirect check is now clean.

Hi,
Maybe one should add pip install git+https://github.com/fusionbox/django-importcsvadmin.git to the README for installation instructions. Because it's not always obvious to everyone how to install. Thanks.