CodeFactor found multiple issues last seen at 5886869:

Invalid spacing around the semicolon.

src\FMData.Xml\Requests\FindRequest.cs:20
src\FMData\Requests\RequestQueryInstance.cs:23
src\FMData\Requests\RequestQueryInstance.cs:28

Would be great to be able to switch between apis by swapping implementations that use the same interface.

Ability to Create, Read, Update, Delete.

CodeFactor found multiple issues:

Invalid spacing around the semicolon.

src\FMData.Xml\ExtensionMethods.cs:84
src\FMData\ContainerForAttribute.cs:13
src\FMData\ContainerForAttribute.cs:13

CodeFactor found an issue: A C# document may only contain a single class at the root level unless all of the classes are partial and are of the same type.

It's currently on:
src\FMData.Rest\Requests\FindRequest.cs:46

Hello,

Maybe I'm wrong in running the code but I have a class "Members" that has more than 20 fields and I run client.FindAsync (toFind) I always have an error.

Indeed, toFind contains my class (with string and int) and sends the complete class.

I feel like this perform find is trying to find a record in Filemaker that has exactly the same values than my class and not just "Member_Zkp_WEB".
The problem is that my class model contains some var who doesnt exist in Filemaker. But it looks like it tries to perform the find on the whole class skeleton.

If comment almost all my vars in my class and i only let Member_Zkp_Web and for example Member_LastName the perform find works en results is giving me the correct record it found.

ViewBag.sessionv contains 26, which exist on my layout.

                FileMakerRestClient client = new FileMakerRestClient("https://fms171.hostmy.solutions", "helloJAK", userName, password);
                var toFind = new Models.Members { Member_Zkp_WEB = ViewBag.sessionv };
                var results = await client.FindAsync(toFind);

Token management should be transparent to the consumers via the main interface.

Token should be automatically refreshed when necessary assuming default timeout of 15min.

When performing an empty find request, the client should switch to the underlying get records api to avoid throwing or returning nothing.

Is your feature request related to a problem? Please describe.
Unable to take advantage of ASP.NET Core 2.1's HttpClientFactory.

Describe the solution you'd like
Encapsulate the connection parameters server, database, user, password into a class/model which can be registered with dependency injection frameworks in conjunction with the existing HttpClient parameter to more thoroughly take advantage of HttpClientFactory.

https://www.stevejgordon.co.uk/httpclientfactory-named-typed-clients-aspnetcore

Describe alternatives you've considered
Could also accept an instance of HttpClientFactory instead of HttpClient, but that might require giving up Net Standard 1.3.

CodeFactor found multiple issues:

The code must not contain multiple blank lines in a row.

src\FMData\IFileMakerApiClient.cs:119
Commit cf1beb3
src\FMData.Rest\IFileMakerRestClient.cs:43
src\FMData.Rest\Responses\AuthResponse.cs:14
Commit 956595f

A closing curly bracket must not be preceded by a blank line.

src\FMData.Rest\Responses\AuthResponse.cs:15
Commit 956595f

The existing Request Factories are protected which limits their usefulness to outside consumers that would rather utilize the SendAsync overloads than the Create, Find, Edit, Delete methods on the client.

Need to determine if it makes sense to replace the existing protected methods, make them public, or make the public methods consume the protected overloads, keeping both.

Navigating the test projects is challenging due to the organic nature in which they were added. They need to be reorganized to more clearly map to the method under test.

With so many overloads its challenging to track down different bits of code. If the client class was refactored to utilize partial classes grouping like methods it would make discovery and maintenance a lot easier.

CodeFactor found an issue: A C# document may only contain a single class at the root level unless all of the classes are partial and are of the same type.

It's currently on:
src\FMData.Rest\Responses\AuthResponse.cs:17

CodeFactor found multiple issues:

A C# document may only contain a single class at the root level unless all of the classes are partial and are of the same type.

tests\FMData.Xml.Tests\TestModels\Art.cs:19
tests\FMData.Rest.Tests\TestModels\PortalModel.cs:20

Need to make sure we're properly handling the conversion from Request to the http request.

Replace [Table], [JsonProperty], and [JsonIgnore] with [DataContract] and [DataMember] and [NotMapped].

FileMaker Find for record that doesn't exist returns HTTP 500 with response content. Same for other error types.

Could utilize existing sql generators to provide basic fql dialect support.

Need the ability to load up related data from portals.

Need the ability to supply the 'omit' parameter on a find request key/value pair of fields.

Need to add support for range of records API.

https://fmhelp.filemaker.com/docs/16/en/restapi/#work-with-records_get-records

https://fmhelp.filemaker.com/docs/16/en/restapi/#perform-find-requests

Hey,

I'm trying to use the ContainerData but i always receive an error which is "Object reference not set to an instance of an object.".
My container contains a picture on my layout and in my model i've created a byte[] to receive it.

        [ContainerDataFor("Picture_gr")] // use the name in your C# model
        public byte[] Member_Picture { get; set; }

Maybe i'm doing something wrong but there is only 4 lines of code...

                FileMakerRestClient client = new FileMakerRestClient(serverName, fileName, userName, password);
                var toFind = new Models.Members { Member_Zkp_WEB = ViewBag.sessionv };
                var results = await client.FindAsync(toFind);
                await client.ProcessContainers(results);

Did you know about this error? Maybe you know a workaround or how to fix it?

Thx in advance!

Korp

https://fmhelp.filemaker.com/docs/16/en/restapi/#set-global-fields

Describe the bug

If the container field url is empty from the data api, an exception is thrown when trying to HTTP GET that blank uri.

To Reproduce

_client.ProcessContainers(model); // where one model has empty uri

Expected behavior

That record to be skipped.

fmdata version

v2.1.0

Describe the solution you'd like
Make use of https://github.com/kzu/GitInfo to better match versions to the repository.

CodeFactor found an issue: Duplicate Code

It's currently on:
src\FMData.Xml\ExtensionMethods.cs:48-61
src\FMData.Xml\ExtensionMethods.cs:26-39

Maintain support for existing [Table] but also check for [DataContract] attribute as well.

Add NET Standard 2.0 target for consumers that are able to use it: https://github.com/dotnet/standard/blob/master/docs/versions.md#how-do-i-know-which-net-standard-version-i-should-target

Task list:

• Update IFileMakerClient with GetDatabasesAsync method
• Define database response type (IEnumerable or a whole new type?)
• Write Rest client implementation
• Write Xml client implementation, reference fmDotNet structure
• Test data, harness, and coverage

note: this api uses basic authentication, the same as getting a token

Put functionality into base class directly and remove interface.

The find API call returns nested array - as in the example below (NestedActions).

I would like apply the following query: get all records that have fielddata.ES_UTC_Time >= 63397939255000 and apply the same date filter against the NestedActions::ES_UTC_Time.

{"query":[{"ES_UTC_Time":">= 63397939255000"},{"NestedActions::ES_UTC_Time":">= 63397939255000"}],"offset":"1", "limit":"100","sort":[{"fieldName":"ES_UTC_Time","sortOrder":"descend"}]}

I would like to return the parent record even if there are no child NestedActions.

Is this even possible when using the FM API find call ? How would I need to structure the fmdata filter to achieve this?

Appreciate a any help with this.

Thanks.

Data:
{
"response": {
"data": [
{
"fieldData": {
"ES_RECORD_ID": 5.1424603688874037043940639545611105393e+37,
"ES_UTC_Time": 63677801587705
},
"portalData": {
"NestedActions": [
{
"recordId": "26",
"NestedActions::ES_UTC_Time": 63675911309428,
"NestedActions::ES_RECORD_ID": 3.58945963486201731120694061631247244196e+38,
"modId": "0"
},
{
"recordId": "27",
"NestedActions::ES_UTC_Time": 63677800967265,
"NestedActions::ES_RECORD_ID": 4.11367583929358143594030872930602025971e+38,
"modId": "0"
}
],
"FormBeforeEventTimeline": [],
"FormAfterEventTimeline": []
},
"recordId": "46",
"modId": "12"
},
{
"fieldData": {
"ES_RECORD_ID": 2.32825376899054305232124784142823827507e+38,
"ES_UTC_Time": 63675551352139
},
"portalData": {
"NestedActions": [],
"FormBeforeEventTimeline": [],
"FormAfterEventTimeline": []
},
"recordId": "45",
"modId": "15"
}
]
},
"messages": [
{
"code": "0",
"message": "OK"
}
]
}

Need to reference the metadata to determine the type of column conversion before adding to the key/value dictionary.

Is your feature request related to a problem? Please describe.
Unable to set global field values for xml requests.

Describe the solution you'd like
Need to manage a small queue on the SetGlobalField implementation; that will add the global field data to the next outgoing request.

Describe alternatives you've considered
Specify the global field as part of the request directly, this is kind of ugly and dirties up the intent of the consuming code.

Additional context
Details on the documentation: https://fmhelp.filemaker.com/docs/16/en/fms16_cwp_guide.pdf#G8.76964

Hello,

This is a very handy library.

I'm getting the JsonReaderException: Unexpected character encountered while parsing value: [.

I wonder whether the it's trying to parse an encoded response. I don't see any invalid characters in the JSON itself...

Thanks,

Peter

Is your feature request related to a problem? Please describe.
Should not need two calls to process containers.

Describe the solution you'd like
Add flag to request model to indicate if containers should be processed or not.

Describe alternatives you've considered
Open to suggestions.

Describe the bug

Edit requests ModId and RecordId should be defined as int

Expected behavior

Use of RecordId and ModId are int everywhere else; and it should be consistent throughout the project.

fmdata version

v2.1.0

Using ASP.NET Core DI is difficult due to ambiguous constructors on the data api client. Needs to be streamlined and run through some testing.

Data API does not return blob data for container fields, it only returns the url/path to the binary data.

API Response structure looks to have changed, as does the endpoints: https://fmhelp.filemaker.com/docs/17/en/dataapi/

Couple things...

• Update IFileMakerClient with GetProductInfoAsync
• Setup Product Info Response Type
• Update Rest Client
• Update Xml Client
• Test coverage / updates

Instead of parsing the json to iDictionary, it would be very handy to get the raw json in addition to the dictionary

Base class exposes a static GetTableName method that should be renamed to GetLayoutName since that is how it is used and what it actually does, since both data and xml apis are layout based.

CodeFactor found an issue: Duplicate Code

It's currently on:
src\FMData.Rest\FileMakerRestClient.cs:647-667
src\FMData.Xml\FileMakerXmlClient.cs:346-366
Commit 6d1e734