ga-wdi-boston / upload-client Goto Github PK

View Code? Open in Web Editor NEW

3.0 3.0 122.0 57 KB

License: Other

HTML 12.21% JavaScript 86.01% CSS 1.78%

upload-client's Introduction

File upload with express and AWS S3

Prerequisites

Objectives

By the end of this, developers should be able to:

Upload files from a browser

Preparation

Fork and clone this repository.
Create a new branch, training, for your work.
Install dependencies with npm install.

Introduction

This repo is part of the browser-upload sequence. If you came here first, you likely want to go check out browser-upload repo, and come back when prompted. The api that we'll eventually use with this client is express-api-upload.

Discussion

The point of this repo is to show the difference between sending data across the internet. Up until now, we've only ever sent JSON. Using this repo in coordination with the other repos in this sequence, we'll build a full feature photo upload!

License

All content is licensed under a CCBYNCSA 4.0 license.
All software code is licensed under GNU GPLv3. For commercial use or alternative licensing, please contact [email protected].

upload-client's People

Contributors

Stargazers

Watchers

Forkers

edesilets knguyen21 byau realweeks resource11 carlamays24 philschoof soynog natdjerf jcornmanhomonoff michaelb167 sjf125 rdelvallej32 olivia-leach susandaiute louarnos roobscoobs lcurran erinsul esthercordova huey1021 sarahhartwick shireen-bean andreasantarl acobrelo tfavazza berziiii mishaherscu jrhorn424 mattb5 jacobhereford payne-chris-r modularjon alex-braun dvdpwll natgalynker echoxin gabescarbrough natasapeic jlmitch1989 gaand viohlet jaimegaribaldo7 wmcb91 abeers knoddin laurenallegra rosmith76 bmorse09 bullhead242 tuckyeah rhjones nishkixs chrxtina nlkassad julie1013 styletabtech kopius jenboyd akradin jbuzzanco ielole ioncrash treep78 akadane87 jdaly04 naki21 sujkid matthewgsommers kibs86 neugierige bowers96 sphilippe7 kmg1434 kiraamaa kfili bengitscode samordonez wilsonkaya laurpaik-zz ddobson s0phi4 dsweetser akgoode cob0910 ashlenprice novakw267 doremaxime skylarkj soboscott zchenbonterra squirtlesquad1988 moshiko1988 newayliu1 lbreguet cshea93 ladypinetree jwaskow alexkarasik antleo1995

upload-client's Issues

Additional resources for the curious wrt to ACL policies

Great finds @nlkassad

Update from template

"I don't know what the name of this repo ought to be"

@gaand

(Based on template naming conventions)

Upload to a file and then stream to AWS S3.

This would be a more realistic solution.

Include instructions to fork clone and npm install

@gaand

Change instructions to rename instances of template

from express-template to express-api-template via @gaand

Add clarification of directory name for express-multer-api

Once you save the express-template as express-multer-api, the instructions on installation in the express template says rename all instances of express-template to name of app.

Make clear that this should match express-multer-api

Perform a diff on index.html

I'm not sure what @payne-chris-r wanted here, so hopefully he can illuminate.

Reference "Create path names" is unclear

In the Objectives section the mention "Create path names" is unclear. As a reference to file path it should have additional context.

Wrong name for `npm run`

"npm run bin/upload-aws [comment]"

should be

"npm run upload-aws [comment]"

Discuss naming for this sequence

Is this to long?

Use plain html form to test upload

No JavaScript.

Add file to this repo?

Remove the httpbin part?

Trying to think of creative ways to cut this talk down, and I wonder if creating an echo server instead of using httpbin might be a better/more effective transition state?
i.e. instead of using POST httpbin you POST to localhost, and your create function in the uploads controller, it just says:

res.json({ body: req.body })

or something like that.

express-api-template should have api at the end

Break apart?

There is certainly value to "building a whole feature" in one go. However, it's also clear that by the end of a 9 hour code-along, the developers are fried. My concern is by the end they don't care and are just making sure they write what we write and not thinking about WHY. I sprinkled in why did I just write what I just wrote?s and what does this code do?s and if I change this '(data)' to '(blah)' what else do I have to change in order for my code to still work?s, but I'm still concerned there is a severe lack of understanding and more of a 'going through the motions'. Not sure how to resolve or if it's even possible...