gabrielperales / elm-soundcloud-player Goto Github PK

I think the code is starting to be too big to be just in one file, but I'm not sure about what approach I should follow to accomplish this task.

Currently player starts counting elapsed time as soon as we press the play button, but it should wait until the player is actually playing the song.

I should use the media event listener canplay. https://developer.mozilla.org/en-US/docs/Web/Guide/Events/Media_events

We have detected a problem with your Greenkeeper config file 🚨

Greenkeeper currently can’t work with your greenkeeper.json config file because it is invalid. We found the following issue:

1. The package path elm-package.json in the group default is invalid. It must be a relative path to a package.json file. The path may not start with a slash, and it must end in package.json. Allowed characters for a path are alphanumeric, underscores, dashes and the @ symbol (a-zA-Z_-@).

Please correct this and commit the fix to your default branch (usually master). Greenkeeper will pick up your changes and try again. If in doubt, please consult the config documentation.

Here’s an example of a valid greenkeeper.json:

{
  groups: {
    frontend: {
      packages: [
        'webapp/package.json',
        'cms/package.json',
        'analytics/package.json'
      ]
    },
    build: {
      packages: [
        'package.json'
      ]
    }
  },
  ignore: [
    'standard',
    'eslint'
  ]
}

This files tells Greenkeeper to handle all dependency updates in two groups. All files in the frontend group will receive updates together, in one issue or PR, and the root-level package.json in the build group will be treated separately. In addition, Greenkeeper will never send updates for the standard and eslint packages.

🤖 🌴

When I'm playing a song and I play other song, elapsed_time keeps counting from the elapsed time of the last song.

Sometimes it is not being triggered when we scroll to the bottom of the page; sometimes it does, it has a weird behaviour.

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

add a section explaining how to create a .env file with the soundcloud client id