Giter VIP home page Giter VIP logo

Comments (5)

gadenbuie avatar gadenbuie commented on May 30, 2024

Thanks for the detailed and easy to reproduce bug report! There was an issue with how I handled groups that start and end at the same point in the input string, which I think I've fixed.

If you can please try the branch fix-issue-9 and let me know that it's resolved, that would be great. (Use devtools::install_github("gadenbuie/regexplain@fix-issue-9")).

You should see results similar to this:

image

Regarding your second issue, unfortunately I haven't been able to get the newer version of RStudio to work on my laptop (MacOS), so I can't diagnose it at this time. I can replicate the issue with RStudio 1.0 or 1.1 (on Mac/Unix). FYI, the expected behavior is for the following to be written to the console:

pattern <- "2017" # perl=TRUE
replacement <- "2018"

from regexplain.

HanOostdijk avatar HanOostdijk commented on May 30, 2024

I have tried your fix-issue-9 fix and this gives the display you mentioned above.
So I would say: issue resolved.

However this only works if I have used the library(bindrcpp) statement in the session before.
This is not specific for your fix-issue-9 fix because it also occurred in the standard version.
If bindrcpp is not present it is apparently loaded by the applet. The attached screenprint shows a warning (NB I understand why I get the warning) in the RegEx panel and none of the selected groups are indicated (but the Output panel is okay: i.e as in the screenprint in the first message).

RegEx panel with message:
without_bindrcpp

Regarding the other issue: you probably meant to say I can not replicate the issue with RStudio 1.0 or 1.1 (on Mac/Unix).? Meaning you have no errors there?

from regexplain.

gadenbuie avatar gadenbuie commented on May 30, 2024

Yes, you’re right I meant to say I can’t reproduce the issue in RStudio 1.0 and 1.1.

Thanks for following up! I’ll try to look into this a bit more and see if I can reproduce the issues you’re seeing.

from regexplain.

HanOostdijk avatar HanOostdijk commented on May 30, 2024

My remarks in earlier comments where all related to RStudio Version 1.2.502
Just now I installed version 1.1.442 (apparently the latest regular version) and tried your fix-issue-9 fix.

The Send RegEx to Console button works here indeed and the issue with groups that start and end at the same point is indeed resolved. But also with 1.1.442 the execution of the library(bindrcpp) statement before using regexplain is necessary to see the groups in the RegEx panel.

from regexplain.

gadenbuie avatar gadenbuie commented on May 30, 2024

Glad to hear the fix and the buttons are working in RStudio 1.1. I've opened #10 to track future issues with RStudio and version 1.2.

I can't reproduce the issue with bindrcpp. That package is imported by dplyr and I'm thinking that maybe having installed the binary version of bindrcpp on Windows with R 3.4.1 when the binary was built against R 3.4.4 might be the culprit. I don't have easy access to a Windows machine available, so I can't reproduce. But I'm going to remove the dependency on dplyr (#11), which shouldn't be hard to do and will resolve this issue.

from regexplain.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.