gaearon / todos Goto Github PK

It seems to me that withRouter doesn't pass route params to nested components. When following the tutorial I used react-router 2.8.1, which I belive needs to explicitly pass down the params from parent component to child.

Is there a way to achieve the same that you showed in your tutorial?

Best regards!

I've cloned the branch for the lesson 27 "Updating Data on the Server" and installed dependencies using npm install. However the link for showing all todos is always rendered as non-clickable text. Only way to see all todos is manually changing url to localhost:3000. I can't see a problem from looking at FilterLinkcomponent.

I was wondering what is the reason to keep an array containing all the ids of the todos. An array of ids can be obtained by calling Object.keys() on the normalised state. I see this pattern reoccurring in other redux related tutorials.

instead of

import { Schema, arrayOf } from 'normalizr';

export const todo = new Schema('todos');
export const arrayOfTodos = arrayOf(todo);

use

import { schema } from 'normalizr';

export const todo = new schema.Entity('todos');
export const arrayOfTodos = new schema.Array(todo); 

Not sure if this is happening to other people or just me. Just downloaded the project to follow along the course but I keep having ESLint errors. On every import I have "Unable to resolve path to module".

Atom 1.17.0
macOS Sierra 10.12.4

Isn't it alpha? should we really use this version?

Correct me if I'm wrong but, based on VisibleTodoList's mapStateToProps, won't this kind of thing trigger component rerenders for every dispatch()ed action in the app? Because the function returns a new array everytime so shallow comparing it won't work for pure components.

Shouldn't these kind of patterns be avoided? @gaearon