gamajo / genesis-theme-toolkit Goto Github PK

This repo fails good package design, in that it contains a collection of classes that may not all be used. If someone just wanted to use the Breadcrumb brick for instance, they'd need to pull in all of gamajo/genesis-theme-toolkit. It should be more granular than that.

Genesis Sample, and therefore multiple child themes, contains a responsive-menu.js.

This should be supportable with a Brick that can pass in (via wp_localize_script() using the genesis-sample-responsive-menu as the default handle ) config-set values for:

• menuClasses (combine + others)
• menuIconClass
• subMenuIconClass
• mainMenu (text)
• subMenu (text)

And:

• handle (of the responsive menu script, so it can attach correctly. Default is genesis-sample-responsive-menu)
• name (default of genesis_responsive_menu)

See here for an example.

Genesis Theme Toolkit currently pulls in version ^0.4 of Theme Toolkit, not the latest version 0.5.0.

FooterCreds was added in commit 68398d8, but it does not extend the base Brick class.

The file header comment in the ThemeSettings.php file references Utility Pro.

<?php
/**
 * Utility Pro.
 *
 * @package   Gamajo\GenesisThemeTookit
 * @author    Gary Jones
 * @copyright Gamajo
 * @license   MIT
 */

With CSS Grid, we shouldn't hopefully need quite as a deep a structure as the default Genesis gives (i.e. number of nested divs and containers).

The genesis() function should now be flexible enough, through the use of callbacks hooked into action hooks which can be removed, and the use of genesis_markup() calls which can be filtered, to provide a much shallower markup, especially for those aimed at layouts with no sidebars.

See https://github.com/srikat/genesis-starter/blob/951dceabb110e5c8826b5610273a9b08c97bc07b/functions.php#L103-L138