gatopeich / gatotray Goto Github PK

When running gatotray without a configuration file, it tries to free a string that has not been allocated on the first change in the text field of the preferences dialog. Playing around with the code, the following patch fixed it for me, but I don't know if that is a correct fix:

diff --git a/settings.c b/settings.c
index 7eb0e30..7e84c95 100644
--- a/settings.c
+++ b/settings.c
@@ -144,9 +144,12 @@ void pref_init()
     for(PrefString* s=pref_strings; s < pref_strings+G_N_ELEMENTS(pref_strings); s++)
     {
         GError* gerror = NULL;
-        *s->value = s->default_value;
+        *s->value = g_strdup(s->default_value);
         gchar* value = g_key_file_get_string(pref_file, "Options", s->description, &gerror);
-        if(!gerror) *s->value = value;
+        if(!gerror) {
+          g_free(*s->value);
+          *s->value = value;
+        }
     }
     preferences_changed();
 }
-- 
2.25.4

Hi there, there are two gatotray packages on Arch but they are terribly out of date and one doesn't have the right source link

https://aur.archlinux.org/packages/gatotray-git
https://aur.archlinux.org/packages/gatotray

I get that it's a random maintainer, I can try to reach out to them, but it would be awesome if you could release an updated one.

E.g. today mate-session's cumulative CPU time kept growing fast because its window-manager (marco) was crashing repeatedly. Standard top just displayed 5% CPU usage for mate-session and was not capturing the crashing children because they were dying in less than 3 seconds.

In this case, gatotray correctly shows mate-session taking >50% CPU while default top shows a meager 5% because it does not count dead subprocesses.

It would be nice to produce a user notification on such scenarios. It could be detected with the new process-tracking code, and also comparing cumulative versus non-cumulative times.

Hi, I don't know if this project is still active but I really love having the graphical tray monitor. I am on Budgie and recently with the update the tray icon no longer shows (BuddiesOfBudgie/budgie-desktop#446)

Any way this could be updated to using a newer tray library? thanks