gavant / ember-shopify-draggable Goto Github PK

Right now the functionality of {{draggable-group}} and {{droppable-group}} are pretty bare-bones. They are good building blocks for more complex functionality, but on their own, they don't do much more than emitting the basic events when items are dragged and dropped.

One thing we can do to increase their usefulness is when events are emitted, instead of only sending an argument with the raw event to the action, also send along an optional "model" that is associated with the item that was dragged, dropped, etc.

For example:

<DroppableGroup
    @droppableActions={{hash
        dropped=(action "droppableDropped")
    }}
    as |Group|
>
    <Group.container as |Container|>
        <Container.dropzone as |Dropzone|}}
            <Dropzone.item @item={{item}}>{{item.name}}</Dropzone.item>
        </Container.dropzone>
        <Container.dropzone as |Dropzone|></Container.dropzone>
    </Group.container>
<DroppableGroup>

actions: {
    droppableDropped(event, item) {
        console.log(`The item/model that was dropped was ${item.name}`);
    }
}

Thanks for your work on this. Any chance you can add some examples of testing the drag and drop functionality? For example,

Given a list of 2 elements,
When I drag the first element to the second spot,
then the list is reordered
and the appropriate events fire.

With swapAnimation=true set on a {{sortable-group}}, dragging items within a list can cause items in the list to not be draggable. This seems to only occur if you perform fast drag operations, and possibly only when you release the drag before the swap animation finishes.

It could be that the reorder delay the swap animation introduces is causing our logic for tracking/syncing of the underlying items list array is being thrown off.

With resizeMirror=true set on a {{sortable-group}}, dragging items within a list can cause orphaned mirror elements to appear in the DOM and are "stuck", usually with incorrect dimensions. This seems to happen more often when drag operations happen in quick succession, or when dragging around really fast/wildly.