gavanw / voxelquestiso Goto Github PK

It would seem a simple fix in order to remove the requirement of file locations and replace them with variables. The most obvious choice of location to store these variables would be as environment variables which could be set via the following command:

SET install_location=C:\wamp\www\voxelquestiso

As far as I can see, the location of the folder is set in five locations, one of which is a markdown file that can safely be removed. The other locations, can simply be changed to use this new environment variable. In cleanup.bat, debug_cleanup.bat and cleanupall.bat, all references of the file path will have to be replaced with %install_location% and in VoxelQuest.vcxproj, the path can be replaced with $(install_location).

However, we run into issues when install_location has not been defined, which might confuse people. So I'd suggest having an initial batch file that is always run contain a test for it.

IF "%install_location%" == "" GOTO INSTALL_LOCATION_NOT_FOUND
:INSTALL_LOCATION_FOUND
:: Install location was found successfully
GOTO END
:INSTALL_LOCATION_NOT_FOUND
:: Install location was not found.  Using default
@ECHO The install_location environment variable was NOT detected, using default.
SET install_location=C:\wamp\www\voxelquestiso
GOTO END
:END

During lunching a program I'm getting error:
Error validating shader 129

After adding a bit more logging I have:
Init shader: ../src/glsl/GenerateVolume.c
Error validating shader: 129 Details: active samplers with a different type refer to the same texture image unit

My video card:
$ lspci | grep VGA
01:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Pitcairn PRO [Radeon HD 7850 / R7 265 / R9 270 1024SP]

If cross-platform is going to become an option, it would be a good idea to convert this to a cmake project, and let it handle generating the visual studio projects, as well as dependencies.

Error 1
error MSB3073: The command "../combine.bat
:VCEnd" exited with code 1.
File: C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V110\Microsoft.CppCommon.targets
Line: 124
Column: 5
Project: VoxelQuest

Running on Windows 7 x64, followed the readme's instructions precisely.

In the "Removed unnecessary crap" (1f98ce9) you removed a bunch of files that was no longer necessary. However all of these files still exists in git's history. This results in a "YUGE" repo (286 MB on disk after download).

You need to go through it and rebase out those files. It might even be easier to delete the whole git repo (as you currently only have 9 commits) and re-init the repo as well as re-upload it to github to get rid of all of those files that you don't need.

In b3a728e you also compressed 100 MB of data. And I'm wondering if perhaps those files does not need to be part of the Git repo. And could instead be distributed in another way (maybe as a resource pack you could download from your webpage?). While you indeed need images and DLL's for a game, they are not considered source code, and Git is not designed for big files (adding them to a zip file actually makes this worse! Since this is now one big blob that Git does not know what to do with).

If you in the future wish to allow for cross-platform development then theres no need in distributing DLL files, as these are only for Windows, other platforms uses other ways for shared libraries. So each platform should compile their own libraries. Instead you should list all dependencies this project needs and which versions of them you use. And it would be up too the individual developer too download these dependencies from the web and set up their development environment.

I know I'm asking something huge,
is there anyone willing to scope the feasibility and/or make this project developable,compilable,runnable on OSX and Linux as well as Window.

I apologize for this, but if you have forked this project you should delete your branch and fork the project again. We wiped the commit history to get rid of bloated history and large files. Better this is done early on! (Also, I know little more than the absolute basics of github, so I am sure there is probably a better place to announce this, rather than open an issue? Also, I added in the two pull requests but forgot to take down the names (one person fixed absolute file paths and another added stuff for cmake). Can I get those names to credit them?