gavinjoyce / babel-plugin-remove-functions Goto Github PK

See https://github.com/ember-cli/babel-plugin-filter-imports/blob/v0.2.x/test/test.js#L35-L48

Perhaps babel-plugin-remove-call-expressions?

This addon supports simple destructuring but doesn't yet support nested destructuring such as:

const { run: { later }} = Ember;

I'm not sure that this type of destructuring is good practice, it seems pretty unreadable to me. I also haven't yet come across an ember app which uses this form. Also, the main motivation for this plugin to address ember-cli/rfcs#50 which doesn't include any nested functions.

Input:

const { 
  assert,
  deprecate
} = Ember;

deprecate('message', test);
assert('message', test);
console.log(message);

Expected output:

console.log(message);

(though I don't really think we care if we leave the destructuring around)

Babel 6's API is dramatically different, do you plan to make this plugin compatible?

WIP here to give you some idea of the required changes: paddyobrien@d2a077c

We're appending to callPathsToRemove without clearing when we start processing a new file.

Performance wasn't considered for the initial implementation of this. We should make changes so that the babel plugin does as little work as possible on files which don't have anything to strip

with the config:

{
  removals: [
   {
      global: 'Ember',
      paths: [
        'deprecate' //Ember.deprecate will be removed
      ]
    }]
}

The following code:

console.log('hi there');
Ember.deprecate('this will be removed', test);
deprecate('this will NOT be removed', test);

should become:

console.log('hi there');
deprecate('this will NOT be removed', test);
``

We currently support removing functions that are imported as follows:

import Ember from 'ember';

export default Ember.Component.extend({
  didInsertElement() {
    console.log('didInsertElement');
    Ember.debug('didInsertElement'); //will be removed
  }
});

Do we need to support other types of import? eg:

import { debug } from 'ember'?

Should we handle global uses of Ember too?

https://github.com/emberjs/data/blob/d0a3bbb6e29cff50d5bf3b958e7af752441ffc98/addon/-private/system/store.js#L7

https://github.com/emberjs/data/blob/d0a3bbb6e29cff50d5bf3b958e7af752441ffc98/addon/-private/debug.js