morningstar float16 support about modpoll HOT 5 CLOSED

So, i see float16 is supported in pymodbus.client_payload()

But not in modbus_task.pl

Looks like one charge is needed

            elif "float32" == ref.dtype:
                ref.update_value(decoder.decode_32bit_float())
                cur_ref += ref.ref_width

Duplicate that code and add

  elif "float16" == ref.dtype:
                ref.update_value(decoder.decode_16bit_float())
                cur_ref += ref.ref_width

I can do it if you want as a pull request?

from modpoll.

Hi @mitchell-pioneer ,
Cool, your contribution is most welcome.

Gavin

from modpoll.

Gavin,

I was unable to work with the python packages so I just made changes to one file. here it is.

modbus_task.zip

What this does is provide support for Morningstar solar charge controllers

https://www.morningstarcorp.com/product_category/solar-charge-controllers/

Ill let you know if I find any other issues.

from modpoll.

Hi @mitchell-pioneer ,no worries. I'll merge your changes in the next release. Thanks.
Would be great if you could share your Modbus configure file for Morningstar after you test it out.
Happy coding!

from modpoll.

I'm going to integrate to several of their charge controllers.. I'll send my results when their done.

from modpoll.