Giter VIP home page Giter VIP logo

Comments (2)

mitchell-pioneer avatar mitchell-pioneer commented on July 1, 2024 1

Great suggestions.

I am also considering modifying the docker configuration. I'm using Portainer, and it allows you to specify environment variables from inside that tool. I think I should add it in the contributions section as it will break the existing system.

from modpoll.

gavinying avatar gavinying commented on July 1, 2024

Yeah, that's a nice feature. Also your approach looks good to me.
Here are some points for your consideration,

  1. Backwards compatibility: Current users don't have to modify their existing commands and config files for upgrade
  2. The new code shall allow those additional columns in csv file to be empty if this feature is not required.
  3. Consider adding two columns (low bound / high bound) to make it more generic, which can be used for abnormal detection / alarm use case. Many device vendors provide such register value range in their Modbus documents. I believe it will also cover your use case.

Your contribution is most welcome. Thanks.

from modpoll.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.