Giter VIP home page Giter VIP logo

Comments (4)

gcanti avatar gcanti commented on June 15, 2024

Please provide a reproducible example

from monocle-ts.

lanyusan avatar lanyusan commented on June 15, 2024

Here you go:

Test code:

import { Lens, fromTraversable, Prism } from "monocle-ts";
import { array } from "fp-ts/lib/Array";

const lensData = {
  a: {
    b: {
      c: {
        d: 3,
      },
    },
    p: [
      {
        id: 1,
        name: "Jack",
      },
      {
        id: 2,
        name: "Jon",
      },
      {
        id: 3,
        name: "Jay",
      },
    ],
  },
};

try {
  const r = Lens.fromProp<any>()("a")
    .composeLens(Lens.fromProp<any>()("p"))
    .composeTraversal(fromTraversable(array)<any>())
    .composePrism(Prism.fromPredicate((child: any) => child.id === 4))
    .modify((child) => ({ ...child, name: "Josh" }))(lensData);

  console.log("Failed prism returned old value silently");
  console.log(JSON.stringify(r, null, 2));

  const r2 = Lens.fromProp<any>()("a")
    .composeLens(Lens.fromProp<any>()("p"))
    .composeTraversal(fromTraversable(array)<any>())
    .composePrism(Prism.fromPredicate((child: any) => child.id === 2))
    .modify((child) => ({ ...child, name: "Josh" }))(lensData);

  console.log("Successfully prism modified value of a -> p -> id = 2 from Jon to Josh");
  console.log(JSON.stringify(r2, null, 2));
} catch (e) {
  console.log("Caught error");
}

run with yarn ts-node test.ts

result with no exception

Failed prism returned old value silently
{
  "a": {
    "b": {
      "c": {
        "d": 3
      }
    },
    "p": [
      {
        "id": 1,
        "name": "Jack"
      },
      {
        "id": 2,
        "name": "Jon"
      },
      {
        "id": 3,
        "name": "Jay"
      }
    ]
  }
}
Successfully prism modified value of a -> p -> id = 2 from Jon to Josh
{
  "a": {
    "b": {
      "c": {
        "d": 3
      }
    },
    "p": [
      {
        "id": 1,
        "name": "Jack"
      },
      {
        "id": 2,
        "name": "Josh"
      },
      {
        "id": 3,
        "name": "Jay"
      }
    ]
  }
}
Done in 0.99s.

from monocle-ts.

gcanti avatar gcanti commented on June 15, 2024

This

const r = Lens.fromProp<any>()("a")
    .composeLens(Lens.fromProp<any>()("p"))
    .composeTraversal(fromTraversable(array)<any>())
    .composePrism(Prism.fromPredicate((child: any) => child.id === 4))

is not a Lens, is a Traversal so is working as expected

from monocle-ts.

lanyusan avatar lanyusan commented on June 15, 2024

Ok. I thought they were all called lens in a broader scope.

Can I suggest to make an enhancement to raise a signal if the traversal then modify fails to find the element to update, as in relational database, an update sql could return how many rows have been modified?

It would be nice for some use cases.

Thanks.

from monocle-ts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.