gedalyakrycer / f1-3-c2p1-colmar-academy Goto Github PK

I highly suggest you start incorporating more html5 semantic tags, it has taken over modern practice as the convention. I see place for <main>, <section>, <articles> a probably many more.
https://www.pluralsight.com/guides/html-css/semantic-html?aid=701j0000001heIqAAI&promo=&oid=&utm_source=google&utm_medium=ppc&utm_campaign=CA_Dynamic&utm_content=&utm_term=&gclid=CjwKCAjwlrnNBRBMEiwApKU4PBiUM7wtxiyqNw-6Zoikh6ChlNul6tTL839Zj2h_JNTZcK6PE5WWlRoCiOYQAvD_BwE

I'm not a big fan of version numbering class names like this. Your better off coming up with a more descriptive name. What is different about container1 from container2? 1 and 2 tell me nothing. Some of the other class name are also a little simple and non-descriptive. I would check out BEM naming convention: http://getbem.com/introduction/

https://github.com/GedalyaKrycer/f1-3-c2p1-colmar-academy/blob/master/capstone_colmar/resources/css/style.css#L391

This is a tag not a class, so no . in front of html.
html { }

https://github.com/GedalyaKrycer/f1-3-c2p1-colmar-academy/blob/master/capstone_colmar/resources/css/style.css#L2

I would swap the nav tag with a header tag, and change the ul to a nav. Nav has pretty much replaced the whole list as a nav bar. You can still use lists if you want but the nav is that semantic gold you want to include.

https://github.com/GedalyaKrycer/f1-3-c2p1-colmar-academy/blob/master/capstone_colmar/index.html#L26-L30

Best practice is to load in your css last, this way all the dependent libraries load in first so they are there for your css. Also you css will take precedence over other stylesheets if it is last. Usually it won't matter but in certain situations it can be an issue.

https://github.com/GedalyaKrycer/f1-3-c2p1-colmar-academy/blob/master/capstone_colmar/index.html#L6-L7

Grade: Exceeds expectations

Summary: First of all, the site looks amazing. Easily the best final product I've ever had the pleasure of reviewing. Your code is well thought out and organized. Lots of good techniques here, the animations look great. I created a few issues for tweaks in best practice and organization. At the end of the day if you are working for yourself by yourself you can do whatever you want as long as it doesn't hurt security (for naming convention and organization). But if you are going to be working with other developers or if eventually other developers will be working with your code then it is important to follow convention. Great project, hope you enjoyed the course.