geert-janklaps / cds-launchpad-plugin Goto Github PK

node_modules\cds-launchpad-plugin\src\index.ts:74:39

Shows sometimes and somitemens not...
Cause is that:

Sometime content is of type bytestream.
For me a single .toString() does the trick.

Am I the only one?

@fabiantschirschnitz

If the ui5 apps are written in Typescript this plugin does not seem to work for me. Maybe I am missing some setting?
I use the cds-plugin-ui5 plugin which ties the ui5 build system (typescript compile etc) into cds watch. It seems the setup of cds-launchpad-plugin runs before that process kicks in and there is no Component.js yet.

As a first optimization for:

https://github.com/geert-janklaps/cds-launchpad-plugin/blob/54912eb3b70a0904b1d53c1462385d73bb20fde7/src/index.ts#L15C3-L15C9

maybe something like:
main...GoWale:cds-launchpad-plugin:main

Hi @geert-janklaps,

I would suggest to follow Short and Powerful: Convenient URLs for SAPUI5/OpenUI5 CDN and use ui5.sap.com instead of sapui5.hana.ondemand.com.

Best Regards
Gregor

Unfortunately the documentation at cds-plugins is not yet released. But the GitHub repository for Capire is now online. So cds-plugins.md can be checked there. We also can follow how the cds-plugin-ui5 implement it.

Hi @geert-janklaps,

what do you think about adding a posibility to configure the renderers section in the template. In this example:

https://github.com/gregorwolf/bookshop-demo/blob/main/app/webapp/fiori-ui5-1.106.html#L12

you see how I've disabled the search functionality to avoid requests to InA and ESH_SEARCH_SRV.

CU
Gregor

Hi @geert-janklaps,

maybe I've missed it in the documentation. Is there an option to define the launchpad that is by default available at /$launchpad as the default page (index.html)?

Best Regards
Gregor

Definition:
https://ui5.sap.com/#/topic/be0cf40f61184b358b5faedaec98b2da

hideLauncher (true/false): Indicates that an inbound must not be represented as a tile/link

This change would hide the tiles if they should not be shown on the launchpad

Hi,

in my option this plugin should not load at all if "cds mock XY" is called.

Because this plugin support the UI for the CAP application but is not required for mocked services.
Same issue as on the cds-plugin-ui5:
ui5-community/ui5-ecosystem-showcase#950

regards
Norbert

Hi @geert-janklaps,

I try to follow the best practice described in UI5ers Buzz #54: I18n with supportedLocales and fallbackLocale configuration and added the following to my manifest.json:

{
    "_version": "1.45.0",
    "sap.app": {
        "id": "environments",
        "type": "application",
        "i18n": {
            "bundleUrl": "i18n/i18n.properties",
            "supportedLocales": [
                "en"
            ],
            "fallbackLocale": "en"
        },

Unfortunately that causes this error:

ENOENT: no such file or directory, open '/app/environments/webapp/[object Object]'
    at Object.openSync (node:fs:600:3)
    at Object.readFileSync (node:fs:468:35)
    at /node_modules/cds-launchpad-plugin/src/index.ts:93:31
    at Array.forEach (<anonymous>)
    at cds_launchpad_plugin.prepareAppConfigJSON (/node_modules/cds-launchpad-plugin/src/index.ts:73:25)
    at /node_modules/cds-launchpad-plugin/src/index.ts:34:34
    at Layer.handle [as handle_request] (/node_modules/express/lib/router/layer.js:95:5)
    at trim_prefix (/node_modules/express/lib/router/index.js:328:13)
    at /node_modules/express/lib/router/index.js:286:9
    at Function.process_params (/node_modules/express/lib/router/index.js:346:12)

I would suggest to look by default for:

let i18nPath = cds.root + '/' + element + '/webapp/' + manifest["sap.app"].i18n.bundleUrl;

and fallback only when empty to the current implementation. What do you think?

Best Regards
Gregor

Hi @geert-janklaps,

I have a "reuse library" in my project, and I'm using cds-launchpad-plugin in combination with cds-ui5-plugin.

Now when I want to to use a resource MyResource from my.namespace.library from one of my applications (my.namespace.app1), it won't be able to load that resource (because it's trying to load from
https://ui5.sap.com/resources/my/namespace/library/MyResource.js which is the last resort).

I think two things would need to be changed to enable that use case:

1. cds-ui5-plugin should serve also libraries (as far as I understood, it does not do that at the moment).
2. cds-launchpad-plugin needs to add resourceroots to the UI5 bootstrap element in the sandbox launchpad.

But before I open an issue over at cds-ui5-plugin and try to create corresponding pull requests on both components, I first wanted to check with you (and other potential readers) if there's another solution I might have missed.

Hi,

the README should be updated to reflect the current state.

Cause the setup has changed:

• with using of the cds plugin system - the setup in server.js ist not required
• the option/setting for the launchpad have moved to cds.env...

regards
Norbert

Hi,
I have the requirement to start the Launchpad tiles in different subdirectories.

But the appConfigPath with my own config doesn_t work.

I used this code:
app.use(handler.setup({theme:'sap_horizon', version: '1.99.0', appConfigPath: '/fiori/appconfig/fioriSandboxConfig'}));

Is it possible to implement. If not, could you please adjust

in index.js line 149
// App URL
const url = /${element.replace(cds.env.folders.app, '')}/webapp;

my element 'main-app/app/backend' is replaced to /main-app/backend, but this is wrong. It should be: /main-app/app/backend

Thank you in advance.