geku / docker-client Goto Github PK

View Code? Open in Web Editor NEW

43.0 43.0 22.0 412 KB

Docker client library to access the Docker remote API.

License: MIT License

Ruby 100.00%

docker-client's People

Contributors

Stargazers

Watchers

Forkers

vito sridatta airbnb greglearns eduardschaeli kimh monksoftware troszok mrashlinux cmartinudden rubythonode

docker-client's Issues

Push an image on the registry

API endpoint POST /images/(name)/push allows pushing an image to a given registry. Needs implementation.

Build an image from Dockerfile via stdin

A first implementation of the build endpoint POST /build supports input by GIT URL but should also accept input by stdin.

Attach stdin to container

The attach endpoint allows to open stdin to the container but is currently not supported by Docker client. See http://docs.docker.io/en/latest/api/docker_remote_api_v1.5/#id15

Proposal: Adding timeout for Docker::Connection.perform_request

Docker::Connection.perform_request keeps blocking until Curl::Err::ConnectionFailedError is raised when client cannot connect docker server. I think user of the client should be able to set timeout to give up.

How do you think?

running tests fails on clean checkout

Is there a way to generated the required 'vcr' files?

$ git clone docker-client
$ bundle install --path gems --binstubs
$ bin/rspec
  1) Docker::Connection returns a stream
     Failure/Error: response = subject.stream("/containers/#{id}/attach", params, timeout, {}) do |data|
     VCR::Errors::UnhandledHTTPRequestError:


       ================================================================================
       An HTTP request has been made that VCR does not know how to handle:
         POST http://10.0.5.5:4243/containers/c27ea9b11da9/attach?stdout=1&stream=1

Create an image by importing it

API endpoint POST /images/create supports image creation by sending a tar archive file. Feature should be implemented in docker-client. See http://docs.docker.io/en/latest/api/docker_remote_api_v1.5/#id21

Remove an image: provide response

Current implementation to delete an image does not return the response but actually sends back JSON.

Dockerfile builder

Add support for Dockerfiles.

Tag an image into a repository

API endpoint POST /images/(name)/tag provides tagging an image into a repository and must be implemented in the docker-client. See http://docs.docker.io/en/latest/api/docker_remote_api_v1.5/#id26

Update existing endpoints to API v1.5

All current endpoints target Docker Remote API v1.0 and should be updated to the newest API version.

crashes when included in rails

I added this gem to the Gemfile, Bundled, and Rails currently crashes when I attempt to require 'docker'

The crash is trace trap rails s with no error or relevant log lines.

error handling on Container#show

Calling docker.containers.show(id) on a non-existant container tries to parse the non-json response from docker. I've filed a bug with the docker project to always return json with an error status. Until then it'd be great if docker-client noticed the non-json error responses and returned something sane.

MultiJson::LoadError (795: unexpected token at 'No such container: 7ff996a98fb3
'):

Monitor Docker events

Allow monitoring of Docker events via client, see http://docs.docker.io/en/latest/api/docker_remote_api_v1.5/#id35

Open question is if we should only support polling or/and streaming.

curl partial file error

This might be a problem with my setup, but I wanted to log it here in case its related to this gem's use of curl. About half the time, commands sent from the rails host to the docker host will fail with

PartialFileError: #<Curl::Err::PartialFileError: Curl::Err::PartialFileError>

The two hosts are on the same ethernet switch so no Internet connectivity problems there. I'd be interested to hear if others have run into this. thanks!