generative-design / code-package-p5.js Goto Github PK

P_2_2_4_02 needs to be synchronised with P_2_2_4_01:

• Variable names as much as possible
• Key interaction
• Code cleaning

Was attempting to port P_3_1_4_01.pde and its external classes. Trying to replicate the workings of Ben Fry's TreeMap library proves to be quite difficult. Too many classes. I don't think it's feasible to create a sketch that behaves exactly the same as the Java version. We might have to consider replacing this sketch with one that is less complicated, or at least less awkward to write in JavaScript.

P_3_1_2_02 needs to be synchronised with P_3_1_2_01:

• Variable names as much as possible
• Key interaction
• Code cleaning

P_2_1_2_02 to _04 needs to be synchronised with P_2_1_2_01:

• Variable names as much as possible
• Key interaction
• Code cleaning

P_4_3_1_02 needs to be synchronised with P_4_3_1_01:

• Variable names as much as possible
• Key interaction
• Code cleaning

It might be a good idea to add 'use strict'; to the top of every script. This get rid of many "silent" errors that can occur whilst running JS and promotes writing better code.

Since using p5js version 0.5.14 the speed of drawing things slowed down noticably on my machine. I haven't measured but sketches that are drawing a lot of elements are about four times slower.

Am I the only one with this problem? I haven't found any similar issues posted on https://github.com/processing/p5.js/issues.

loadImage() does not complete loading images on svg's when run in a loop in Firefox (it works for Chrome and in Firefox Developer Edition). See for example in sketch P_2_3_6_02.

P_2_2_1_02 needs to be synchronised with P_2_2_1_01:

• Variable names as much as possible
• Key interaction
• Code cleaning

Currently the imported svg shapes are drawn as images e.g. P_2_3_4_01 and are very pixellated, not so nice. Find a ways to have proper vectors form the SVG to canvas.

P_3_1_3_02 to _04 needs to be synchronised with P_3_1_3_01:

• Variable names as much as possible
• Key interaction
• Code cleaning

Task:

• Porting of https://github.com/generative-design/GenerativeDesignLibrary3/blob/master/src/generativedesign/GenerativeDesign.java#L267 to js
• Add it to generativedesign.js

It seems maybe to be an issue with loadImage() and svg. I get the following error:

InvalidStateError: An attempt was made to use an object that is not, or is no longer, usable  p5.js:14640
	[49]</p5.Renderer2D.prototype.image http://localhost:8000/libraries/p5/p5.js:14640:5
	[61]</p5.prototype.image http://localhost:8000/libraries/p5/p5.js:20795:3
	bound  self-hosted:918:17
	setup http://localhost:8000/01_P/P_2_1_1_04/:62:3
	p5/this._setup< http://localhost:8000/libraries/p5/p5.js:11564:7
	bound  self-hosted:912:17
	p5/this._runIfPreloadsAreDone http://localhost:8000/libraries/p5/p5.js:11507:7
	p5/this._decrementPreload http://localhost:8000/libraries/p5/p5.js:11516:5
	bound  self-hosted:914:17
	[61]</p5.prototype.loadImage/img.onload

While something seems to get loaded when testing the loadImage() with a callback, if you try to console.log() any of the images in the shapes array, it doesn't return anything in Firefox.

Things seem to work in Chrome.

I'm wondering if the class should be more general in terms of data input. But then it might be changing something in the printed code...

P_2_3_6_02 needs to be synchronised with P_2_3_6_01:

• Variable names as much as possible
• Key interaction
• Code cleaning

Changing the image and pressing one of the sorting keys multiple times, I always get different results. That can't be right.

Hi @Niels-NTG, could you fix this one at some time? Ran into it accidentally ... not urgent. Best, B

P_2_2_3_02 needs to be synchronised with P_2_2_3_01:

• Variable names as much as possible
• Key interaction
• Code cleaning

Would be cool the extent modes with http://gka.github.io/chroma.js/

P_2_1_4_02 to _05 needs to be synchronised with P_2_1_4_01:
-Variable names as much as possible
-Key interaction
-Code cleaning

Either improve P_2_1_4_05 or delete it.

• lerpColor with key 2 is buggy, seems to be an bug in p5.js. Bug report is issued processing/p5.js#1029
• if (key == 'c' || key == 'C') GenerativeDesign.saveASE();
• Would be cool the extent modes with http://gka.github.io/chroma.js/

P_4_2_1_02 needs to be synchronised with P_4_2_1_01:

• Variable names as much as possible
• Key interaction
• Code cleaning

P_2_3_7_MacPaint_TABLET needs to be synchronised with P_2_3_7_MacPaint_1:

• Variable names as much as possible
• Key interaction
• Code cleaning

Remove MacPaint from sketch names and rename to _01 and _02_TABLET

P_4_1_2_02 needs to be checked and synchronised with P_4_1_2_01:

• Variable names as much as possible
• Key interaction
• Code cleaning

Attention: the _01 sketch wasn't working correctly. Now it should. But there might be the same problem with the _02

P_4_2_2_02 needs to be synchronised with P_4_2_2_01:

• Variable names as much as possible
• Key interaction
• Code cleaning

Hi @joeyklee

Reorganised the centralised /data folder and introduced a dedicated readme. Could you please cross check whether understandable/spelling?

https://github.com/generative-design/Code-Package-p5.js/blob/pre-release/data/README.md

cc @Niels-NTG

Hi @Niels-NTG @joeyklee @bohnacker, hope this github issue finds you alle well!

It think it would be a good idea to do some maintenance for the new/upcoming version JP/EN of the book. There will be a new wave of attention and we should be best possible prepared for this. Hence could all of us invest a little time in this? I'm thinking of:

• Update p5.js dependency to the most recent stable p5.js version
• @joeyklee could you reach out to your p5.js friends and ask for advice? Which recent version is the best bet for long term support?
• Create a dev branch for this
• Check and fix every sketch, with local webserver
• Check and fix every sketch, with the http://alpha.editor.p5js.org/generative-design/
  ...

Happy to split the work ... :)

PS. @Niels-NTG kind of related ... is there still the plan to have the sketches running interactively on http://www.generative-gestaltung.de/2/

P_2_0_02 to _03 needs to be synchronised with P_2_0_01:

• Variable names as much as possible
• Key interaction
• Code cleaning

P_2_1_3_02 to _05 needs to be synchronised with P_2_1_3_01:

• Variable names as much as possible
• Key interaction
• Code cleaning

P_2_1_5_02 to _04 needs to be synchronised with P_2_1_5_01:

• Variable names as much as possible
• Key interaction
• Code cleaning

P_1_2_3_02 to _04 needs to be synchronised with P_1_2_3_01:

• Variable names as much as possible
• Key interaction
• Code cleaning

We need it, because there will be images of it in the book.

Missing:

• if (key == 'c' || key == 'C') GenerativeDesign.saveASE()
• GenerativeDesign.sortColors()
  if (key == '5') sortMode = GenerativeDesign.HUE;
  if (key == '6') sortMode = GenerativeDesign.SATURATION;
  if (key == '7') sortMode = GenerativeDesign.BRIGHTNESS;
  if (key == '8') sortMode = GenerativeDesign.GRAYSCALE;

Task:
Implment sortColor() in generativedesign.js. Has to be most likely be implemented with webworkers: http://www.html5rocks.com/en/tutorials/workers/basics/

P_1_2_3_02 to _05 needs to be synchronized with P_1_2_3_01:

• Variable names as much as possible
• Key interaction
• Code cleaning

How can we assign sketches so that we don't work on the same ones? Create an issue for each one? or maybe submit a comment on this issue with what each contributor is working on.

P_2_3_1_02 needs to be synchronised with P_2_3_1_01:

• Variable names as much as possible
• Key interaction
• Code cleaning

P_2_3_6_02 needs to be synchronised with P_2_3_6_01:

• Variable names as much as possible
• Key interaction
• Code cleaning

P_2_2_2_02 needs to be synchronised with P_2_2_2_01:

• Variable names as much as possible
• Key interaction
• Code cleaning

Hi @Niels-NTG @bohnacker @joeyklee!

Just tweaked the IMO very last things for the 1.0 release of the code packe / repo. Please cross-check. Will go online tomorrow/Tuesday morning 8 CET. Please fix/change what should go in.

🚀Yay!

Best,
B

P_2_2_5_02 needs to be synchronised with P_2_2_5_01:

• Variable names as much as possible
• Key interaction
• Code cleaning

We should keep the code closer to the already learned commands. Of course, having the circles as Objects is a good way to do it, but is completely new for the reader at this point. That might be confusing.
Still, we could keep this kind of code for P_2_2_5_02.

P_2_1_1_02 to _04 needs to be synchronised with P_2_1_1_01:

• Variable names as much as possible
• Key interaction
• Code cleaning

@Niels-NTG

The new index look much nicer! Many thanks for this!

Quickly two small comments:

• there are some broken images
• would vote to crop all images to square format (also on gg website)

Could you fix this?

P_4_3_3_02 needs to be synchronised with P_4_3_3_01:

• Variable names as much as possible
• Key interaction
• Code cleaning

I've already done a recursive version, but didn't use it for word counting. If anybody has a good idea, if we could do something nice with it, we could still do it.

Very low priority

@b-g
Regarding getting the sketches into the p5-web-editor, the idea is to pull the sketches from github. However, this means we would need to put the "encapsulated" sketches somewhere on github. Problem is that when the sketches contain the GG library, etc for each sketch the projects is an unweildy ~610mb (~550 excluding the node_modules).

Question is, should we put the encapsulated code package in the generative-design org or in a separate dummy account?

thanks!

@joeyklee

Could you go once more over the readme?

At the moment it reads like you have to install node to run everything, but running index.html in any kind of local webserver would be enough. Could you make the node thing more optional and point out that any local webserver will do?