georgemandis / 101-hello-worlds Goto Github PK

Currently the following examples are failing:

• 41
• 45
• 46

Those should be examined to make sure there isn’t in fact something broken with them, but for 41 and 46 at least the issues lies in globalThis not existing in the Node version the GH action runs in (See issue #14).

It’ll be cumbersome to fix, but I think moving each file into its own folder with a corresponding .nvmrc file might be the way forward (Or maybe use asdf if I’m feeling…fun?).

Once I do that and the template is there is shouldn’t be that hard to maintain going forward.

While I’m doing this I might want to reexamine the test suite and see if I can better accommodate more adventurous solutions.

#19 and #20 are the accidentally the same. Either I'll fix #20 or the next merged request gets to be reassigned.

One of the solutions works in v11.4.0 but not other versions of Node. I blame my own lack of diligence.

Still, it raises an interesting question. I've got a GitHub action running the tests now. Should I pick a version of Node that all the solutions have to work under and stick with that? Should I explore a fancier fix where each solution can post something like it's own .nvmrc file and modify the tests to use the requests version of Node?

Decisions decisions...