Comments (10)
ianthetechie
commented on June 11, 2024
2
@gibbz00 I wasn't going to come in all guns blazing, but yeah, that was actually my first thought 🎃
from geo.
gibbz00
commented on June 11, 2024
Match arms that should not be triggered usually use unimplemented! over todo!, so my two cents are that this is in fact a todo 🙂
from geo.
urschrei
commented on June 11, 2024
@bbetov-clgx blame says this is your todo. wdyt?
from geo.
bbetov
commented on June 11, 2024
@urschrei Indeed, it is a todo!. I haven't had a chance to come back to it to finish, but if the OP already has a solution, great!
from geo.
urschrei
commented on June 11, 2024
@ianthetechie If you have a PR, we'd be happy to have it.
from geo.
fegies
commented on June 11, 2024
Hi. Is there any update on this? A project of mine was recently bitten by this, so I'd be willing to put a quick PR if there is not one already in progress.
from geo.
ianthetechie
commented on June 11, 2024
Not at the moment; I realized that I didn’t need this formula (Cartesian was OK for very close distances) for our use case and I haven’t gotten back to this yet.Asking the obvious question, why would it be anything other than the intersection variant?There’s also a similar TODO waiting to blow up in the same file IIRC.11/22/23 03:43, Felix Giese ***@***.***> 작성:
Hi. Is there any update on this? A project of mine was recently bitten by this, so I'd be willing to put a quick PR if there is not one already in progress.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
from geo.
fegies
commented on June 11, 2024
Well, there might be the degenerate case of multiple points of the Linestring actually intersecting.
So the correct behavior in that case would be to return Closest::Indeterminate.
I'll prepare a PR with a repro and a fix
from geo.
ianthetechie
commented on June 11, 2024
Valid point ;)11/22/23 04:00, Felix Giese ***@***.***> 작성:
Well, there might be the degenerate case of multiple points of the Linestring actually intersecting.
So the correct behavior in that case would be to return Closest::Indeterminate.
I'll prepare a PR with a repro and a fix
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
from geo.
fegies
commented on June 11, 2024
PR ready for review:
#1119
from geo.
Related Issues (20)
- MultiPoint::len
- Panic in BooleanOps::union for Polygon<f32> HOT 6
- VecSet may cause panics HOT 7
- Proposal: Common abstraction layer for collection types (via `Deref` and `DerefMut`) HOT 2
- Add delauney triangulation algorithm to root `geo` crate docs index
- Thoughts on algorithms for trait-based geometries
- concave_hull returns nonsense results for simple polygons HOT 1
- Panic in RegionAssembly reproducibly HOT 4
- Clarify that current cross-track distance uses spherical (Haversine) earth model, add Ellipsoidal (Vincenty) version HOT 2
- Missing `contains` implementations
- `is_valid` for all geometry types. HOT 3
- Problems building with Rust 1.75.0 HOT 1
- Add is_equal_topo method to IntersectionMatrix to determine topological equality
- How to calculate intersection area of two rotated rectangles? HOT 2
- Missing PointZ implementations HOT 1
- Latest ahash dep and Rust 1.70.0 are incompatible HOT 4
- 3D (3-dimensional) data types HOT 2
- Rhumb destinations do not wrap angles after the first pole intersection HOT 8
- GeodesicDestination produces cyclcically incosistent results HOT 5
- Expose fields in AffineTransform struct (or have a way to access the internal values)? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from geo.