Comments (4)
Optimally Polling the server to check if the payment has been received would be the best option, but I can see it might not always be possible.
Maybe we can have a allowExternalPayment
boolean that is default to true. If false, it hides the external payment options.
CC @reneaaron @bumi
from bitcoin-connect.
should we consider yet another section with a text field (from) for introducing the preimage manually
No, I think users should never have to manually paste a preimage. Most people have no idea what it is, and I'm not sure what they gain from doing this or even where they get that preimage from
from bitcoin-connect.
It also makes sense to only show the external options in some cases. I wonder if instead we add a property paymentMethods
which can be "all"
or "internal"
or "external"
from bitcoin-connect.
Polling the server to check if the payment has been received would be the best option
Agree. We take the preimage as proof of payment so it's possible that the server/service that takes the credentials does not have access to an invoice status.
Maybe we can have a allowExternalPayment boolean that is default to true.
I agree that by default most of the people want it set to true. So whatever route we follow (showEncodedInvocie
or hideEncodedInvoice
the default should to have the QR visible.
Also, should we consider yet another section with a text field (from) for introducing the preimage manually (I would go with no, but in case you see it necessary)
from bitcoin-connect.
Related Issues (20)
- closeModal function should be async HOT 3
- The connect wallet modal needs a cancel or "x" button because I can't close it from mobile. HOT 2
- Improve accessibility HOT 4
- Incorrect copy in mobile pay component HOT 5
- Expose API through a single object instead of exported methods
- Cannot paste in connection string to nostr wallet connect field. HOT 13
- Add Start9 connector
- Support Tauri HOT 1
- Update currency selector UI
- Support NWA HOT 1
- HTMLElement is not defined HOT 1
- Change Bitcoin Connect to only boot when `init` function is called
- Docs should mention if you manually set window.webln, you should listen to the onDisconnected event and remove it from the window HOT 9
- Pay Button - Cannot close modal when selecting a wallet to connect to HOT 1
- Relay gets blasted with get_balance requests if NWC service does not implement get_balance command HOT 1
- Stuck loading if NWC connection string is not valid HOT 1
- Lightning Node Connect Setup- Fails Silently HOT 4
- Mutiny UI changed to get the NWC string. HOT 1
- Add a way to disconnect when the connector is loading
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bitcoin-connect.