Giter VIP home page Giter VIP logo

Comments (4)

rolznz avatar rolznz commented on July 21, 2024 1

Hi @positiveblue

Optimally Polling the server to check if the payment has been received would be the best option, but I can see it might not always be possible.

Maybe we can have a allowExternalPayment boolean that is default to true. If false, it hides the external payment options.

CC @reneaaron @bumi

from bitcoin-connect.

rolznz avatar rolznz commented on July 21, 2024 1

should we consider yet another section with a text field (from) for introducing the preimage manually

No, I think users should never have to manually paste a preimage. Most people have no idea what it is, and I'm not sure what they gain from doing this or even where they get that preimage from

from bitcoin-connect.

rolznz avatar rolznz commented on July 21, 2024 1

It also makes sense to only show the external options in some cases. I wonder if instead we add a property paymentMethods which can be "all" or "internal" or "external"

from bitcoin-connect.

positiveblue avatar positiveblue commented on July 21, 2024

Polling the server to check if the payment has been received would be the best option

Agree. We take the preimage as proof of payment so it's possible that the server/service that takes the credentials does not have access to an invoice status.

Maybe we can have a allowExternalPayment boolean that is default to true.

I agree that by default most of the people want it set to true. So whatever route we follow (showEncodedInvocie or hideEncodedInvoice the default should to have the QR visible.

Also, should we consider yet another section with a text field (from) for introducing the preimage manually (I would go with no, but in case you see it necessary)

from bitcoin-connect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.