Comments (9)
nostrband
commented on June 20, 2024
1
I was talking about Alby NWC connection, it's probably harder to do when BC just wraps the existing webln provider.
from bitcoin-connect.
nostrband
commented on June 20, 2024
1
Hmm ok maybe it should be the app's job to react to disconnect properly. Especially given that if you're just forwarding the existing webln provider then it's harder to make it get "disconnected" if app saves a reference to it and doesn't react to disconnect properly.
I guess onConnected docs could state that this provider object may still be usable even after user clicks "disconnect" so app should react to onDisconnected properly.
from bitcoin-connect.
rolznz
commented on June 20, 2024
I would be happy for a PR for this if you know a good solution. Would it just be deleting webln from the window object?
from bitcoin-connect.
nostrband
commented on June 20, 2024
I guess the provider could start throwing exceptions on all access methods?
from bitcoin-connect.
rolznz
commented on June 20, 2024
But how do we tell the provider to do that? Maybe we could propose a disable method in webln https://www.webln.guide/building-lightning-apps/webln-reference
from bitcoin-connect.
rolznz
commented on June 20, 2024
@nostrband do you use Bitcoin Connect v3? by default it will not set window.webln. If you decide to set it yourself, then you must also delete it when the user disconnects their wallet
from bitcoin-connect.
nostrband
commented on June 20, 2024
Yeah I'm using v3 and I'm clearing window.webln after disconnect
from bitcoin-connect.
rolznz
commented on June 20, 2024
@nostrband so is there anything we can do here? or should we update the docs so it's clear if you set window.webln you should also listen to the disconnected event and delete window.webln?
from bitcoin-connect.
rolznz
commented on June 20, 2024
Thanks @nostrband for the clarification.
from bitcoin-connect.
Related Issues (20)
- closeModal function should be async HOT 3
- The connect wallet modal needs a cancel or "x" button because I can't close it from mobile. HOT 2
- Improve accessibility HOT 4
- Incorrect copy in mobile pay component HOT 5
- Expose API through a single object instead of exported methods
- Cannot paste in connection string to nostr wallet connect field. HOT 13
- Add Start9 connector
- Support Tauri HOT 1
- Update currency selector UI
- Support NWA HOT 1
- HTMLElement is not defined HOT 1
- Change Bitcoin Connect to only boot when `init` function is called
- Remove external payment options from payment request modal HOT 4
- Pay Button - Cannot close modal when selecting a wallet to connect to HOT 1
- Relay gets blasted with get_balance requests if NWC service does not implement get_balance command HOT 1
- Stuck loading if NWC connection string is not valid HOT 1
- Lightning Node Connect Setup- Fails Silently HOT 4
- Mutiny UI changed to get the NWC string. HOT 1
- Add a way to disconnect when the connector is loading
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bitcoin-connect.