Giter VIP home page Giter VIP logo

Comments (9)

chelout avatar chelout commented on May 26, 2024 1

I've updated screenshots links

from sentry-laravel.

ehfeng avatar ehfeng commented on May 26, 2024

None of the links point to screenshots. Can you please update?

from sentry-laravel.

ehfeng avatar ehfeng commented on May 26, 2024

For context, I spoke with @chelout separately. His main concern is that Array content is not displayed in the stack locals (strings and integers, for example, are). Is it possible we collect and send these as well?

My assumptions is that we're using PHP's default behavior in stringify arrays when we log the error context passed to us and if it's possible to get the Array values.

I don't know enough about the Laravel client to say for sure though.

from sentry-laravel.

dcramer avatar dcramer commented on May 26, 2024

@chelout could you confirm the version of sentry/sentry you're using?

from sentry-laravel.

chelout avatar chelout commented on May 26, 2024

The latest version

from sentry-laravel.

dcramer avatar dcramer commented on May 26, 2024

I wonder if we have the thresholds incorrect. What I believe is happening is its saying "this is recursing too much, just show the Repr version of this instead", which shouldn't be the case here.

from sentry-laravel.

bretthoerner avatar bretthoerner commented on May 26, 2024

Yep, our max recursions are 3 which gets you (from his screenshot) data (1), leads (2), and then update (3) at which point we check $_depth < $max_depth and anything that level or lower gets the short serialization.

Do we just want to bump our default levels here or do we do anything smarter in other SDKs? We don't do anything smart in the Java SDK (which I'm familiar with).

from sentry-laravel.

dcramer avatar dcramer commented on May 26, 2024

@bretthoerner the original goal was to reflect what the server does, which is semi-dumb, but i think also varies based on the type of data.

from sentry-laravel.

stayallive avatar stayallive commented on May 26, 2024

As per getsentry/sentry-php#554 this limit was increased in sentry/sentry version 1.9.0 which should solve this. Please reopen if it's still an issue with that version of the PHP SDK.

from sentry-laravel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.