gettyimages / gettyimages-api_php Goto Github PK

The automated build is not running for pull requests and pushes to main. Looks like a simple fix in the build.yml file.

In the GettyImages_Client constructor is not compatible with PHP 8.0+ because $container comes after an optional parameter.

Hi there,

I found the OAuth refresh token scenario where I can authenticate with that, but I couldn't find any way to bypass that in case I stored the access token. Is this possible?

Using the library in Version "gettyimages/gettyimages-api": "^5.1" triggers deprecation warnings like this:

PHP Deprecated:  Optional parameter $options declared before required parameter $filepath is implicitly treated as a required parameter in /[...]/vendor/gettyimages/gettyimages-api/src/Request/WebHelper.php on line 104

I already opened a PR to fix it: #26

PR #16 enabled usages of newer versions of PHP-DI, however it also introduced a bug due to the removal of the DI\object() function in PHP-DI 6.x:

[30-Sep-2021 14:10:29 UTC] PHP Fatal error:  Uncaught Error: Call to undefined function DI\Object() in /var/www/html/vendor/gettyimages/gettyimages-api/src/GettyImages_Client.php:102
Stack trace:
#0 /var/www/html/vendor/gettyimages/gettyimages-api/src/GettyImages_Client.php(121): GettyImages\Api\GettyImages_Client->__construct()
#1 /var/www/html/app/getty/container.php(41): 

(partial stack trace)

Note the removal in PHP-DI's upgrade guide: https://github.com/PHP-DI/PHP-DI/blob/master/doc/migration/6.0.md#diobject

Hey guys,

as far as I can see there is no other possibility to set the "accept-language" header other than by changing the source code of your php SDK. Or am I missing here something? It would be really handy if I could set additional curl options e. g. via a method in der FluentRequest class which will pass the options to the WebHelper object once it has been created. Is something like that planned in the near future or am I on my own on this?

Thanks,
Andreas