ggeorgovassilis / circuitjs1 Goto Github PK

Those classes belong to different files

Create a proper package structure in preparation of refactoring

Move some members and methods from CircuitElem around.
Moved static variables to CircuitSim as they affect the entire simulation run.
Moved colour and init static methods to CircuitSim

as a side effect, majorly refactored project (using old gwt-maven plugin, adhering to default maven directory structure)

Hi George!

I see you did quite a lot of changes ~March last year. But I don't see any PR's in the original repos.
What exactly did you change? What/Why?
(unfortunately your commit messages are not telling much...)

Thanks in advance.

CircuitElm (and inheriting classes) should separate logic from representation

Currently it seems that a queue of work packages is first drained before user interactions are being processed. This seems to happen on at least these two occasions:

1. When the user stops a heavy simulation it should stops ASAP; instead the simulation continues for a while
2. When the user rearranges an element the circuit should be updated immediately; again, the simulation seems to continue for a while before the circuit is updated