Function call in test.c

estimate_rating_from_factors(0, 0, learned, model)

gives the following error

test.c: In function ‘main’:
test.c:80:4: error: incompatible type for argument 2 of ‘estimate_rating_from_factors’
estimate_rating_from_factors(0, 0, learned, model));

Function prototype from recommender.h

double
estimate_rating_from_factors(rating_estimator_parameters_t* estim_param,
struct learning_model model);

Comment from above prototype has 4 arguments while you have only defined 2.

Hi There,

This project is still using an old implementation of LGTM's automated code review, which has now been disabled. To continue using automated code review, and receive checks on your Pull Requests, please install the GitHub App on this repository.

Thanks,
The LGTM Team

the generate_random_matrix is using srand(0) to generate random number everytime.

srand(0) sets the seed of the random number generator to 0. Calling it again with the same parameter sets the seed to 0 again, and will cause the random generator to create the same output.

e.g.
srand(0);
for(int i = 0; i<5; i++)
printf(" %d ", rand());
return 0;

prints 1804289383 846930886 1681692777 1714636915 1957747793 all the time (should use something like srand(time(0)))

So the matrix is not generated randomly as it should be.